Skip to content

Commit

Permalink
Clarify the reviewer window title
Browse files Browse the repository at this point in the history
"1 day 2" seems really strange to me. "1 day 2 hours" would be too
long for most smartphone. But "1 day 2h" seems reasonable to me

Also, "plural" does not allow for two parameters, and it would have
been complex to consider both words if they are singular or plural.

Regarding "1 hour 5" I preferred to not change it. "1 hour 5 min" woud
add far too many character. "1 hour 5m" sounds strange. And stating "1
hour 5" is far more standard than "1 day 5"
  • Loading branch information
Arthur-Milchior committed Sep 22, 2024
1 parent 4eab9d1 commit 2689bac
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions AnkiDroid/src/main/res/values/01-core.xml
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,8 @@
<item quantity="other">%1$d hours %2$d left</item>
</plurals>
<plurals name="reviewer_window_title_days_new">
<item quantity="one">%1$d day %2$d left</item>
<item quantity="other">%1$d days %2$d left</item>
<item quantity="one">%1$d day %2$dh left</item>
<item quantity="other">%1$d days %2$d h left</item>
</plurals>
<string name="no_cards_placeholder_title">Collection is empty</string>
<string name="no_cards_placeholder_description">Start adding cards\nusing the + icon.</string>
Expand Down

0 comments on commit 2689bac

Please # to comment.