Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Bug] Change color of Checkbox in AlertDialog #15174

Closed
4 tasks done
SanjaySargam opened this issue Jan 8, 2024 · 12 comments · Fixed by #16552 or #16549 · May be fixed by #16515
Closed
4 tasks done

[Bug] Change color of Checkbox in AlertDialog #15174

SanjaySargam opened this issue Jan 8, 2024 · 12 comments · Fixed by #16552 or #16549 · May be fixed by #16515
Assignees
@Thejas775
Labels
Good First Issue! UI
Milestone
2.19 release

Comments

@SanjaySargam
Copy link
Contributor

Reproduction Steps
  1. Go to Manage Space
  2. Click on Delete backups
  3. Click on any one of the Checkbox Item
Expected Result

The color must match with App's theme i.e. @color/material_light_blue_500

Actual Result

The color is default which is light green
WhatsApp Image 2024-01-08 at 9 33 40 AM

Debug info

AnkiDroid Version = 2.17alpha14-debug (1bb9883)

Backend Version = 0.1.32-anki23.10.1 (23.10.1 fac9e0ee1436ba5ac3366c72dd9394a6e692b1cf)

Android Version = 13 (SDK 33)

ProductFlavor = amazon

Manufacturer = realme

Model = RMX3521

Hardware = qcom

Webview User Agent = Mozilla/5.0 (Linux; Android 13; RMX3521 Build/RKQ1.211119.001; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/120.0.6099.144 Mobile Safari/537.36

ACRA UUID = 499dd159-a9b7-4067-bc7f-31d815ef70de

Crash Reports Enabled = false

Research

Enter an [x] character to confirm the points below:

  • I have read the support page and am reporting a bug or enhancement request specific to AnkiDroid
  • I have checked the manual and the FAQ and could not find a solution to my issue
  • I have searched for similar existing issues here and on the user forum
  • (Optional) I have confirmed the issue is not resolved in the latest alpha release (instructions)
@SanjaySargam SanjaySargam mentioned this issue Jan 8, 2024
Closed
5 tasks
@github-actions GitHub Actions

This comment was marked as outdated.

# to view
@github-actions github-actions bot added the Stale label Apr 7, 2024
@evanOGrady
Copy link

I would like to take on this issue.

@SanjaySargam
Copy link
Contributor Author

Sure go ahead

@Giyutomioka-SS
Copy link
Contributor

@evanOGrady Are you still working on this, or can I take this up?

@evanOGrady
Copy link

@Giyutomioka-SS
You can take this on. I thought I would have more free time to do this.

@Thejas775
Copy link

@Giyutomioka-SS are you still working on this or can i be assigned ?

@Giyutomioka-SS
Copy link
Contributor

Giyutomioka-SS commented May 26, 2024 •
edited
Loading

You can take this on. @Thejas775

@Giyutomioka-SS Giyutomioka-SS removed their assignment May 26, 2024
@Thejas775
Copy link

@david-allison please assign me this issue

@david-allison
Copy link
Member

Done, cheers!

@Thejas775 Thejas775 mentioned this issue May 26, 2024
Closed
5 tasks
neeldoshii added a commit to neeldoshii/Anki-Android that referenced this issue May 31, 2024
@neeldoshii @SanjaySargam @Thejas775
Migrated AlertDialog to Material 3
660ee79 
Fixed : Change color of Checkbox in AlertDialog in AsyncDialogs.kt ankidroid#15174
Migrated AlertDialog of AsyncDialog to Material3 (MaterialAlertDialog) Related ankidroid#13878

Co-Authored-By: Sanjay Sargam <sargamsanjaykumar@gmail.com>
Co-Authored-By: Thejas Elandassery <58774753+thejas775@users.noreply.github.com>
@neeldoshii neeldoshii mentioned this issue May 31, 2024
Draft
5 tasks
@MorenoTropical MorenoTropical mentioned this issue Jun 5, 2024
Merged
5 tasks
@github-actions github-actions bot added this to the 2.19 release milestone Jun 5, 2024
@neeldoshii
Copy link
Contributor

Seems like issue still exists.

Light Dark
screenshot screenshot

@david-allison david-allison reopened this Jun 5, 2024
@david-allison
Copy link
Member

@MorenoTropical could you confirm?

@MorenoTropical
Copy link
Contributor

Hi. I had noted in the PR that it would be fixed after that and my other PR #16549 were fixed, but I did the error of putting the issue number after the word Fixes.

I'm sorry for that.

But it should be fixed after my other PR is merged.

@MorenoTropical MorenoTropical mentioned this issue Jun 5, 2024
Merged
5 tasks
@mikehardy mikehardy modified the milestones: 2.19 release, 2.20 Release Aug 29, 2024
@github-actions github-actions bot modified the milestones: 2.20 Release, 2.19 release Sep 16, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@Thejas775 Thejas775

Labels
Good First Issue! UI
Projects
None yet
Milestone
2.19 release
8 participants
@mikehardy @Thejas775 @evanOGrady @neeldoshii @david-allison @SanjaySargam @Giyutomioka-SS @MorenoTropical