Migrate AsyncDialogs to Material 3
#16515
Draft
+33
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed : Change color of Checkbox in AlertDialog in AsyncDialogs.kt ankidroid#15174 Migrated AlertDialog of AsyncDialog to Material3 (MaterialAlertDialog) Related ankidroid#13878 Co-Authored-By: Sanjay Sargam <sargamsanjaykumar@gmail.com> Co-Authored-By: Thejas Elandassery <58774753+thejas775@users.noreply.github.com>
This comment was marked as outdated.
This comment was marked as outdated.
|
Seems like incomplete |
|
Created Styling to support for both API Level
The above screenshots is of Delete Restore Backups following black,dark,plain, light theme Android 13 (Plain, Light, Dark, Black)
Android 8 (API 26) (Plain, Light, Dark, Black)
|
neeldoshii
commented
Jun 4, 2024
| @@ -105,6 +105,9 @@ | |||
| <!-- AlertDialogTheme--> | |||
| <item name="alertDialogTheme">@style/AlertDialogStyle</item> | |||
|
|
|||
| <!-- MaterialAlertDialog--> | |||
| <item name="materialAlertDialogPrimaryColor">@color/theme_black_primary_dark</item> | |||
There was a problem hiding this comment.
I am still confused how is this taking light grey color in the dialog where here I have passed <color name="theme_black_primary_dark">#000000</color>. Not sure why its not overriding leading both theme_black and theme_dark somehow both of the theme has same color.
PS : This is my first time working into theming.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the issue was that the colour of the checkbox was not matching with the APP theme
@color/material_light_blue_500. Initially, my thought process was to add a style in the Theme to ensure the checkbox color matches the app theme. However, I later realized that migrating to Material3 would be a better approach, as it allows the checkbox color to adapt dynamically based on the app theme. Since we plan to migrate to Material3 eventually, this seems like the most forward-thinking solution.🌟 h/t to thank @SanjaySargam for helping inspire this solution with Changed color of Checkbox in AlertDialog #15184
🌟 h/t to thank @Thejas775 for helping inspire this solution with Changed color of the checkbox in alertdialog #16485
Fixes
Steps to Reproduce
Screenshot/Video
asyndialog.mp4
Approach
In the PR :)
Learning (optional, can help others)
https://github.com/material-components/material-components-android/blob/master/docs/components/Dialog.md
Checklist
Please, go through these checks before submitting the PR.