Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[BUG]: String of review count at bottom of deck picker screen overflows #14641

Open
4 tasks done
snowtimeglass opened this issue Nov 2, 2023 · 12 comments · May be fixed by #16965
Open
4 tasks done

[BUG]: String of review count at bottom of deck picker screen overflows #14641

snowtimeglass opened this issue Nov 2, 2023 · 12 comments · May be fixed by #16965
Labels
Milestone

Comments

@snowtimeglass
Copy link
Contributor

This string might be a bit too long (on single line) to support multiple languages and size of screens.
image
image
image
image
Display size: 6.4 inches
Resolution: 1080 x 2400 pixels

Debug info
AnkiDroid Version = 2.17alpha3 (42a8c8c55c200f372b0bd0b462e4b58554b72fe5)

Android Version = 11

ProductFlavor = play

Manufacturer = OPPO

Model = CPH2013

Hardware = qcom

Webview User Agent = Mozilla/5.0 (Linux; Android 11; CPH2013 Build/RKQ1.200903.002; wv) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/117.0.0.0 Mobile Safari/537.36

ACRA UUID = 460ff45d-dade-406e-b1ac-56d9175ebdb5

Crash Reports Enabled = true

DatabaseV2 Enabled = true

Research

Enter an [x] character to confirm the points below:

  • I have read the support page and am reporting a bug or enhancement request specific to AnkiDroid
  • I have checked the manual and the FAQ and could not find a solution to my issue
  • I have searched for similar existing issues here and on the user forum
  • (Optional) I have confirmed the issue is not resolved in the latest alpha release (instructions)
@snowtimeglass snowtimeglass changed the title [BUG]: String of review count in deck picker overflows in some languages [BUG]: String of review count at bottom of deck picker screen overflows Nov 5, 2023
@user1823
Copy link
Contributor

As seen in the first screenshot above, this is a problem with the English version too. I don't remember whether this problem existed in v2.16 or not.

@user1823
Copy link
Contributor

This issue didn't occur in 2.16 because the string was shorter:

To solve this issue, the (xs/card) part should either be moved to the next line or it should be removed.

@david-allison
Copy link
Member

Testing string:

今日は⁨1⁩枚のカードを⁨⁨3.02⁩秒⁩で学習しています ( ⁨3.02⁩秒 / 枚 )

@snowtimeglass
Copy link
Contributor Author

snowtimeglass commented Apr 11, 2024

Though the feeling noted in the review below seems a bit excessive to me, it has more support from readers than I expected. image

If they feel that the current information is too much detailed as information on the main screen, I agree with them in the point.

Users can see this information in Statistics screen, so, depending on viewpoint, this information on the main screen is an unnecessary duplicate.

I suppose it would be better to drop not only the "(X s/card)" but also the seconds to decimal point (".XX" of "in X.XX minutes") out of the main screen.

In other words, regarding the main screen, I think it would be better to restore the simple style used in 2.16.

@user1823
Copy link
Contributor

user1823 commented Apr 14, 2024

In other words, regarding the main screen, I think it would be better to restore the simple style used in 2.16.

I think that this needs to be done in the Desktop first because AnkiDroid aims to replicate the behaviour of the Desktop.

Something similar was discussed in an Anki Forums thread and a consensus was built. However, no changes were made. It seems that dae wants more people to request the same before the change is made.

@snowtimeglass
Copy link
Contributor Author

snowtimeglass commented Apr 14, 2024

Thank you. It may be nice if it is done in Anki Desktop.

That said, I'm still not sure that this issue need to be done in Anki Desktop first, because I guess the principle that "AnkiDroid aims to replicate the behavior of the Desktop" does not necessarily apply to this case.

PC screens are generally wider than Android device screens , and to begin with, Desktop doesn't have the info in the main screen. For now I regard it rather as an AnkiDroid specific issue, if anything.

So, for now, I think that placing abridged information on the main screen does not necessarily need waiting for change to be made in the statistics screen of Anki Desktop.

@user1823
Copy link
Contributor

Desktop doesn't have the info in the main screen.

Which version of Anki are you using? Here is a screenshot from 24.04, showing the info on the main screen. IIRC, Anki shows this info on the main screen since at least 23.10.

image

@snowtimeglass
Copy link
Contributor Author

snowtimeglass commented Apr 14, 2024

My bad. You're right.
I overlooked the information in the main screen of Anki Desktop since my decks overflow as follows:
image

I'm sorry for my misinterpretation.
Thank you for pointing it out.

@snowtimeglass
Copy link
Contributor Author

snowtimeglass commented Apr 14, 2024

I'll reconsider this issue.


[Edit]
It might be better to keep the current string itself and make its style like one in Statistics screen;

i.e.

  • to enable the use of second line when the string is long (or constantly use two lines as user1823 mentioned)
  • to make the font smaller

@mikehardy mikehardy modified the milestones: 2.18 release, 2.19 release May 13, 2024
@johncaiwa

This comment has been minimized.

@david-allison

This comment has been minimized.

@johncaiwa

This comment has been minimized.

@MorenoTropical MorenoTropical linked a pull request Aug 26, 2024 that will close this issue
5 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants