Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

2.9 Release coordination #4961

Closed
mikehardy opened this issue Sep 14, 2018 · 17 comments
Closed

2.9 Release coordination #4961

mikehardy opened this issue Sep 14, 2018 · 17 comments
Assignees
@mikehardy @timrae
Labels
Task
Milestone
v2.9 release

Comments

@mikehardy
Copy link
Member

This issue is just to coordinate the release.

We've got a milestone to track items: https://github.com/ankidroid/Anki-Android/milestone/11

I have marked a few items speculatively for inclusion where my intention is to estimate time required and potentially drop them from the release, so the list may change in the next couple days as I drop things that aren't workable
@mikehardy mikehardy added this to the v2.9 release milestone Sep 14, 2018
@mikehardy mikehardy added the Task label Sep 14, 2018
@mikehardy mikehardy mentioned this issue Sep 14, 2018
Open
@mikehardy
Copy link
Member Author

I just focused my goals for the 2.9 release somewhat. Things I really want:

  • advanced notifications to not be "weird" (and per deck group is "weird" to me)
  • audio clip from file (it seems so close?)
  • gui language settings (I had this partially working at one point)
  • tag important analytics things (I'll do a round in a few days)

I'm likely going to ignore the rest.

@mikehardy
Copy link
Member Author

mikehardy commented Nov 23, 2018 •
edited
Loading

@timrae If you pull up the 2.9 milestone page now, I've got it roughly ordered (you can drag issues up and down).

The ordering I'm imposing is this:

  1. any PR (or issue related to a PR) that has is ready for review and can be closed if the review passes and the PR merges is above this 2.9 coordination issue
  2. this issue
  3. any issue that has no pending PR ready for review but would create strings that need localization (thus blocking betas I think?)
  4. any issue that has no pending PR ready for review but does not affect localization

At the moment we've got 3 PRs for v2.9 that I can no longer find problems in but I'd like review on, and one of those depends on a 4th PR (sqlite framework APIs). There are a couple other little PRs that look good to go but aren't 2.9 specific.

What are your thoughts on me merging these in to continue the 2.9 beta push? I've got a little of my confidence back since the upgrade-version issue, built on more textual review passes but I don't want to be pushy and I certainly don't mean to irritate you. I just know you're busy and based on earlier conversations I suspect that will stay the same for a while?

@timrae
Copy link
Member

timrae commented Nov 23, 2018

What are your thoughts on me merging these in to continue the 2.9 beta push? I've got a little of my confidence back since the upgrade-version issue, built on more textual review passes but I don't want to be pushy and I certainly don't mean to irritate you.

Let me check these PRs when I have time. I think you're still a little way off merging your own PRs but maybe soon.

@mikehardy
Copy link
Member Author

I think you're still a little way off merging your own PRs but maybe soon.

I do not disagree :-)

Just knowing your preference is good, I'll hold tight.

@mikehardy mikehardy mentioned this issue Jun 11, 2019
Closed
@mikehardy
Copy link
Member Author

I’ve got all my PRs in shape for merge I think.

I wish I had more time for notifications changes, GUI language etc but it’s been a long time, and we can always release again…

@mikehardy
Copy link
Member Author

mikehardy commented Aug 6, 2019 •
edited
Loading

Hey Mr @timrae! I'm headed home from vacation now. Anything you need from me to finish shaping up 2.9? I don't think I'm on the hook for PRs right now with CardTemplateEditor + Database Versioning on deck for a re-try in 2.10 but I thought I'd check in just in case. I'd be happy to help in general if there's administrivia to finish out as well, I think I have a docs PR for 2.9 staged somewhere etc, maybe translations or a QA pass or whatever. Would love to see 2.9 out so let me know if I can help. Cheers

@timrae
Copy link
Member

timrae commented Aug 11, 2019

I think we're pretty much good to go, the main blocking task now is the release notes I think.

@mikehardy
Copy link
Member Author

starting point here with changes cataloged up to the point of PR submission ankidroid/ankidroiddocs#39

No opinion on what should or should not be included, was just adding about anything I saw in the commit log at the time

@mikehardy mikehardy mentioned this issue Sep 4, 2019
Closed
@adamwolf
Copy link
Contributor

What's left now? Updating mikehardy's release notes?

@mikehardy
Copy link
Member Author

yeah - sorry I haven't gotten to it! feel free to run with it if you want. Just needs a commit scan on the release-2.9 branch from whenever I originally started that PR up to now. There were some nifty features if I recall.

Maybe also adding some sections to the manual for Mathjax, multi-select, card re-scheduling...and I think that's all the features?

@adamwolf
Copy link
Contributor

adamwolf commented Sep 10, 2019 via email

@mikehardy mikehardy mentioned this issue Oct 6, 2019
Closed
@timrae
Copy link
Member

timrae commented Oct 7, 2019 •
edited
Loading

OK the release notes are done now.
I am aiming to do the final release within a week from now.
@adamwolf do you have time to do the mathjax documentation in the user manual.

@adamwolf
Copy link
Contributor

adamwolf commented Oct 7, 2019 via email

@adamwolf
Copy link
Contributor

adamwolf commented Oct 8, 2019

PR for Mathjax docs here: ankidroid/ankidroiddocs#44

@timokau
Copy link

timokau commented Nov 16, 2019

2.9 has just landed on f-droid, so I think this can be closed. Thank you all for your good work!

@mikehardy
Copy link
Member Author

Yeah, agreed there. Need to open one for 2.10 really

@timrae
Copy link
Member

timrae commented Feb 1, 2020

2.9.2 commit log with dependency updates stripped out:
c71c2fe Correct edition of card in filtered deck
4f26834 fix negative due dates in filtered decks
ca42304 Clears undo before changing schedulers
c8a20af New card with same due are shown according to their ord
bcc13aa some html regexps should be case insensitive
43ff6f7 fix crash on app startup with uninitialized collection
ece0b5d escape backslash in find&replace
c4865da Cloze menu (#5536)
037219d Fix Mathjax Cloze duplication issue.
aa94e20 Don't run gitflow-integrate script unless we're on correct branch
21c1838 Adding missing Throw
0c18472 Fix sched v2 overflow bug (#5574)
f609f42 Adding method Parent from Anki
dbf3c09 Decks#checkIntegrity
d402073 Switch to okhttp for http connections, use TLS1.2 on API<=21 (#5658)
c8e6904 intNow to intTime

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@mikehardy mikehardy

@timrae timrae

Labels
Task
Projects
None yet
Milestone
v2.9 release
Development

No branches or pull requests
4 participants
@adamwolf @mikehardy @timrae @timokau