-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
feat(browser): render rows using backend #16620
Draft
david-allison
wants to merge
6
commits into
ankidroid:main
Choose a base branch
from
david-allison:card-browser-backend-render
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
feat(browser): render rows using backend #16620
david-allison
wants to merge
6
commits into
ankidroid:main
from
david-allison:card-browser-backend-render
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-allison
added
Help Wanted
Requesting Pull Requests from volunteers
Review High Priority
Request for high priority review
Blocked by dependency
Currently blocked by some other dependent / related change
labels
Jun 19, 2024
Message to maintainers, this PR contains strings changes.
Read more about updating strings on the wiki, |
david-allison
force-pushed
the
card-browser-backend-render
branch
2 times, most recently
from
June 20, 2024 17:02
a7260eb
to
552596b
Compare
david-allison
added
Needs Author Reply
Waiting for a reply from the original author
and removed
Blocked by dependency
Currently blocked by some other dependent / related change
labels
Jun 20, 2024
This comment was marked as outdated.
This comment was marked as outdated.
david-allison
force-pushed
the
card-browser-backend-render
branch
2 times, most recently
from
July 8, 2024 10:46
ae6184c
to
f8d07af
Compare
david-allison
removed
Review High Priority
Request for high priority review
Has Conflicts
labels
Jul 8, 2024
david-allison
force-pushed
the
card-browser-backend-render
branch
3 times, most recently
from
July 10, 2024 16:31
c38876d
to
d36e659
Compare
david-allison
added
Needs Review
and removed
Needs Author Reply
Waiting for a reply from the original author
Help Wanted
Requesting Pull Requests from volunteers
labels
Jul 10, 2024
david-allison
force-pushed
the
card-browser-backend-render
branch
from
July 10, 2024 16:33
d36e659
to
7449866
Compare
david-allison
force-pushed
the
card-browser-backend-render
branch
from
July 13, 2024 20:16
7449866
to
e8707c3
Compare
This comment was marked as resolved.
This comment was marked as resolved.
david-allison
force-pushed
the
card-browser-backend-render
branch
2 times, most recently
from
August 3, 2024 15:44
b99c94f
to
84e5c09
Compare
This comment was marked as resolved.
This comment was marked as resolved.
5 tasks
david-allison
force-pushed
the
card-browser-backend-render
branch
from
August 5, 2024 15:54
84e5c09
to
97c8e25
Compare
5 tasks
This comment was marked as resolved.
This comment was marked as resolved.
david-allison
added
the
Needs Author Reply
Waiting for a reply from the original author
label
Aug 5, 2024
This comment was marked as resolved.
This comment was marked as resolved.
5 tasks
david-allison
added
Blocked by dependency
Currently blocked by some other dependent / related change
and removed
Needs Author Reply
Waiting for a reply from the original author
labels
Aug 6, 2024
|
5 tasks
david-allison
removed
the
Blocked by dependency
Currently blocked by some other dependent / related change
label
Aug 19, 2024
Up to other maintainers for guidance, but I'd prefer to focus efforts on |
`browserRowForId` accepts either a `NoteId` or a `CardId` depending on the value of `BROWSER_TABLE_SHOW_NOTES_MODE` * CardOrNoteId * represents the ID of a Browser Row * BrowserRowCollection * A collection of the browser rows, along with the context (CardsOrNotes) to know how to obtain the raw cids/nids from the collection
david-allison
force-pushed
the
card-browser-backend-render
branch
from
August 19, 2024 17:20
35c0985
to
ecc20ed
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose / Description
Modify the CardBrowser to use a
RecyclerView
and usebackend.browserRowForId
to obtain the dataThis is significantly faster, reducing or removing the 'jittery' rendering of the Card Browser
In addition, it means we can display the FSRS columns
Since the calls are so fast, we can perform them inside the UI thread
Fixes
Approach
BrowserRowCollection
backend.browserRowForId
: returnsBrowserRow
BrowserRow
RecyclerView
How Has This Been Tested?
Unit tests
Learning
Checklist