fix:[BUG] Key Labels Not Displaying in Landscape Mode

[Prince-kushwaha]

Purpose / Description

Key Labels Not Displaying in Landscape Mode

Fixes

• Fixes [BUG] Key Labels Not Displaying in Landscape Mode #16935

Approach

use linear layout

How Has This Been Tested?

Tested on Android Device

UI Screenshots

Checklist

Please, go through these checks before submitting the PR.

• You have a descriptive commit message with a short title (first line, max 50 chars).
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner

[BrayanDSO]

The issue can be resolved without creating a new layout, which makes the code easier to mantain, so please do that.

Also, this breaks the layout in tablets and screens large enough to properly show the dialog

[Prince-kushwaha]

@BrayanDSO incorporated feedback

[Prince-kushwaha]

@Arthur-Milchior can u please review this pr

[BrayanDSO]

Please don't ping maintainers in such a hurried manner to get this reviewed. This isn't a high priority issue and we will get it whenever we can. Respect the time and availability of other people, please.

[BrayanDSO]

Dialog broken

[Arthur-Milchior]

Please, ideally use a single commit. You can edit your commit and force push the branch.
Use multiple commit if your work is done in multiple steps, to ease review

[Arthur-Milchior]

FYI, you'd make the review faster if you could also provide screenshot for vertical, and tablet. So that it's clear it works everywhere.
And, more importantly, if you could explain why the change was required. What was broken and now works

[Arthur-Milchior]

Dialog broken

Running on the current version of the PR, the dialog seems okay to me. I admit I don't see what's broken.

The dialog is smaller. But I must admit that I don't see any problem with not having it take a lot more space.

[BrayanDSO]

Just to clarify what's broken: the dialog looked a certain way before in portrait mode or in big screens like tablets, and this PR breaks that look while it can easily preserve it and fix the issue at the same time. Don't break something to fix another.

[Prince-kushwaha]

@BrayanDSO I tried to preserve the look of the dialog box in portrait mode but it is not possible using signal layout.xml that preserve portrait mode dialog look and also have responsive in landscape mode.

[Prince-kushwaha]

if have any solution for that .please share it with me

[Prince-kushwaha]

Hi @BrayanDSO , i fixed the dialog broken issue

[mikehardy]

please do not include merge commits
please squash changes to a single commit with descriptive commit title + description