-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Feat[Multimedia]: render svg
using webview
#17035
base: main
Are you sure you want to change the base?
Conversation
Message to maintainers, this PR contains strings changes.
Read more about updating strings on the wiki, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks GREAT to me
Question: does this work for other formats? Because animated PNGs are static in the ImageView, but animated when the card is opened |
2d8f019
to
167baac
Compare
No this method would require workarounds for different images, we can directly use webview to preview images |
So, is it possible to use the WebView instead of an ImageView to preview all the images? That should handle all the images that can be rendered in a flashcard |
Purpose / Description
Render SVG instead of showing a warning text.
Blocked by
Fixes
Approach
Use a webview to render an SVG in it
How Has This Been Tested?
Tested on OnePlus Nord CE:
Checklist
Please, go through these checks before submitting the PR.