Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Refactored DeckPickerWidget to handle empty state visibility. #17041

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

xenonnn4w
Copy link
Contributor

@xenonnn4w xenonnn4w commented Sep 8, 2024

Purpose / Description

Handle empty state visibility, allowing users to reconfigure the widget by clicking the empty state message in the Deck Picker Widget.

Approach

Handled similar to that Card Analysis Widget.

How Has This Been Tested?

image

dop.mp4

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

@david-allison
Copy link
Member

What does this look like?

@xenonnn4w
Copy link
Contributor Author

added in the PR description.

@xenonnn4w
Copy link
Contributor Author

I reviewed the code and noticed an issue with the visibility of empty_deck. I plan to investigate and resolve it when I have more time.

@xenonnn4w
Copy link
Contributor Author

Fixed!

Copy link
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks good - after looking through our back stack management though, I'm curious if we are missing a CLEAR_TOP on the Intent for the reviewer though

Otherwise (that is: the bulk of the PR): looks good

@mikehardy mikehardy added Needs Author Reply Waiting for a reply from the original author and removed Needs Review labels Sep 16, 2024
…ing users to reconfigure the widget by clicking the empty state message.
@xenonnn4w xenonnn4w added Needs Review and removed Needs Author Reply Waiting for a reply from the original author labels Sep 16, 2024
Copy link
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic, I think this looks pretty good and from the video it looks pretty good to me

If you are curious at all - and I mention it because I have seen you do related work so I think you might be interested? - you might look at #17073 to consolidate our usage of these flags...

@mikehardy mikehardy added Needs Second Approval Has one approval, one more approval to merge and removed Needs Review labels Sep 16, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Needs Second Approval Has one approval, one more approval to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants