-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix: export option dialog have text overlapping issue and last checkbox is not visible in landscope mode #17061
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but PR can be rebased
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed with @criticalAY - @Prince-kushwaha we use the merge queue here set to rebase, and I can't rebase-merge a dirty commit history like this. If you'll be making a bunch of PRs (and there are two in the queue now for review) you need to make PRs with a clean commit history
In your local checkout of this branch you want to git rebase and squash these 4 commits to a single commit with descriptive title and description
There should never be commits that are meaningless. like "change"
For me that would be this in a terminal:
git rebase -i HEAD~4
(to get the last 4 commits up in a commit editor- in editor delete
pick
from commits 2-4 and switch tos
for squash - now save the editor and it will make a single commit with all messages together in an editor
- in the editor, delete all the commit messages and make one clean descriptive commit message
- save that, then
git push --force-with-lease
to push that rebase to the branch on github - re-request review
dc6b967
to
e6a5c68
Compare
e6a5c68
to
dc6b967
Compare
…lay correctly in landscape mode
dc6b967
to
76a744d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Much cleaner commit history
@mikehardy Thank you for sharing that with me! I’ve learned a lot from that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
commit history cleaner, and this seems like an okay fix
I know Brayan has strong opinions on UI so asking for a review there
May take a while though, these are not super high priority fixes, so please have patience
Purpose / Description
export option dialog have text overlapping issue and last checkbox is not visible in landscope mode
Fixes
Approach
make layout scrollview
How Has This Been Tested?
physical android device
Screenshot
Checklist
Please, go through these checks before submitting the PR.