Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix : [Bug] The layout of the Axis Picker screen is not displaying correctly in landscape mode #17064

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Prince-kushwaha
Copy link
Contributor

Purpose / Description

The layout of the Axis Picker screen is not displaying correctly in landscape mode

Fixes

Approach

How Has This Been Tested?

Physical android device

##Screenshot

WhatsApp Image 2024-09-14 at 3 47 58 PM

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

Copy link
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • never do merge commits
  • never push commits that are useless like ones that just say "change"

Please rebase this to have only the change you want in a single nice commit with descriptive message

I can't review it otherwise

@mikehardy mikehardy added the Needs Author Reply Waiting for a reply from the original author label Sep 16, 2024
@Prince-kushwaha
Copy link
Contributor Author

@mikehardy review comments are done

Copy link
Member

@mikehardy mikehardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same with this one - my UI skills are weak but I think Brayan is our most skilled UI reviewer, so deferring, but it...appears correct to my not-very-well-trained eye

@mikehardy mikehardy added UI Needs Second Approval Has one approval, one more approval to merge and removed Needs Author Reply Waiting for a reply from the original author labels Sep 20, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Needs Second Approval Has one approval, one more approval to merge UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: The layout of the Axis Picker screen is not displaying correctly in landscape mode
2 participants