Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added multiselect delete in manageNotesType #17091

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jainv4156
Copy link
Contributor

@jainv4156 jainv4156 commented Sep 19, 2024

Added Multiselect delete in manageNoteType

Purpose / Description

Describe the problem or feature and motivation

Fixes

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner
Screencast.from.2024-09-19.12-33-39.webm

Added Multiselect delete in manageNoteType

djsakj

adding payload to reduce ui rendering

Debuging

debugging

debugging

Debugging

Debug

solved errors

remove commented code
@brishtibheja
Copy link

I think the current delete option shouldn't be there. It's weird that we have the same functionality twice. Also, it makes me anxious when the delete option (a high-risk option) is very easy to reach.

Perhaps, long-press then delete can become the default, maintainers?

@jainv4156
Copy link
Contributor Author

jainv4156 commented Sep 19, 2024

you got a point. We can disable the delete option while in multiSelect mode or we can completely remove the default delete button

and there is one more problem. When we long press and multiselct mode enables, the other functionalities like add ,rename ,edit are still accessible. so should we disable them too ?

@brishtibheja
Copy link

I'd say yes, remove all but you may want to wait for the maintainers' opinions.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiselect Note type and delete
2 participants