Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Added AnkiWeb logo to 'AnkiWeb account' screen #17095

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dattasneha
Copy link

@dattasneha dattasneha commented Sep 19, 2024

Purpose / Description

Add AnkiWeb logo to 'AnkiWeb account' screen

Fixes

Approach

Add AnkiWeb logo and make specific changes in required files taking reference from #16672

How Has This Been Tested?

Tested on Android physical device.

Screenshots

Light mode

Before After
WhatsApp Image 2024-09-19 at 10 42 34 PM WhatsApp Image 2024-09-20 at 2 45 45 PM
WhatsApp Image 2024-09-19 at 10 42 35 PM WhatsApp Image 2024-09-19 at 10 43 58 PM

Dark mode

Before After
WhatsApp Image 2024-09-20 at 3 34 23 PM WhatsApp Image 2024-09-20 at 3 23 56 PM (1)
WhatsApp Image 2024-09-20 at 3 37 00 PM WhatsApp Image 2024-09-20 at 3 23 56 PM

Learning (optional, can help others)

Describe the research stage

Links to blog posts, patterns, libraries or addons used to solve this problem

Checklist

Please, go through these checks before submitting the PR.

  • You have a descriptive commit message with a short title (first line, max 50 chars).
  • You have commented your code, particularly in hard-to-understand areas
  • You have performed a self-review of your own code
  • UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
  • UI Changes: You have tested your change using the Google Accessibility Scanner

Copy link

welcome bot commented Sep 19, 2024

First PR! 🚀 We sincerely appreciate that you have taken the time to propose a change to AnkiDroid! Please have patience with us as we are all volunteers - we will get to this as soon as possible.

@brishtibheja
Copy link

How does this look like in dark mode? Does the star's inside have the background colour? I think that's how it should look like.

@david-allison david-allison added the Needs Author Reply Waiting for a reply from the original author label Sep 20, 2024
Copy link
Member

@david-allison david-allison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

This doesn't look like the proposed de#:

Could you check on the issue/#ankidroid-design for a consensus on the design, then make any changes once consensus is reached

@snowtimeglass
Copy link
Contributor

snowtimeglass commented Sep 20, 2024

Thank you for PR. For now, the logo in the light mode screen looks good to me.

Can you replace the screenshot for login screen after the change? (The current screenshot there seems a duplication of the already-logged-in screen after the change.)


As for the color setting of the "AnkiWeb" text (image), it may need to be changed so that the color switches to black/white in light/dark mode, like the other characters below the logo.

image

image

@dattasneha
Copy link
Author

How does this look like in dark mode? Does the star's inside have the background colour? I think that's how it should look like.

@brishtibheja added the screenshots for dark mode. PTAL.

Could you check on the issue/#ankidroid-design for a consensus on the design, then make any changes once consensus is reached

@david-allison Done. Wrote a message on discord channel and made the suggested changes. PTAL.

Thank you for PR. For now, the logo in the light mode screen looks good to me.

Thanks @snowtimeglass, replaced the screenshot with the correct one and changed the text color for dark mode as well. PTAL.

@snowtimeglass
Copy link
Contributor

Thank you for the changes. The "AnkiWeb" text looks good to me.


As for the star, perhaps it might be more desirable for the team to approach the upstream to inquire if they could provide the data of the "genuine" AnkiWeb star logo.
image

@david-allison
Copy link
Member

Can we move discussion of the design back to the issue.

In particular: I personally feel the designs in #16300 (comment) are better, and we should define what we want this pull request to do before it's reviewed, otherwise there will be a lot of back & forth here

@snowtimeglass
Copy link
Contributor

The two-icons-connection concept is also attractive for me, but its design might need some more adjustment. The thin-gray connecting line in the suggested image still doesn't look good enough to me:

(an example image for alternative)
image

That said, I'm still not sure whether requesting such change of concept and design would be good in this pull request.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Needs Author Reply Waiting for a reply from the original author New contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[suggestion] Add AnkiWeb logo to 'AnkiWeb account' screen
4 participants