Fixes Mathjax inside of a cloze replacement.

[adamwolf]

Pull Request template

Purpose / Description

Mathjax wasn't being rendered inside of cloze replacements. I tracked it down to clozeText() which was eating the backslashes needed for \(.

Fixes

#5323

Approach

Escapes the backslashes.

How Has This Been Tested?

I created a test to replicate the issue. It now passes. The old tests still pass.

Checklist

Please, go through these checks before submitting the PR.

• You have not changed whitespace unnecessarily (it makes diffs hard to read)
• You have a descriptive commit message with a short title (first line, max 50 chars).
• Your code follows the style of the project (e.g. never omit braces in if statements)
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code

[mikehardy]

With a test even 💪 👍 - if/when CI goes green I'll merge, thanks @adamwolf

[mikehardy]

uh-oh - a nope in CI:

com.ichi2.libanki.ClozeTest > testCloze FAILED
    java.lang.AssertionError
        at org.junit.Assert.fail(Assert.java:86)
        at org.junit.Assert.assertTrue(Assert.java:41)
        at org.junit.Assert.assertTrue(Assert.java:52)
        at com.ichi2.libanki.ClozeTest.testCloze(ClozeTest.java:51)

[adamwolf]

I pushed a potential fix. I upgraded Android Studio and I'm having a bit of trouble running the whole test suite (probably my side) but I think this update should help.

…

On Mon, Jun 10, 2019 at 12:30 PM Mike Hardy ***@***.***> wrote: uh-oh - a nope in CI: com.ichi2.libanki.ClozeTest > testCloze FAILED java.lang.AssertionError at org.junit.Assert.fail(Assert.java:86) at org.junit.Assert.assertTrue(Assert.java:41) at org.junit.Assert.assertTrue(Assert.java:52) at com.ichi2.libanki.ClozeTest.testCloze(ClozeTest.java:51) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5324?email_source=notifications&email_token=AAAIWYOLXSOWJFDAE4RPNVDPZ2FRZA5CNFSM4HWVG6JKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXKRZ6Y#issuecomment-500505851>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAAIWYO7AE7ZBPJIN52EMODPZ2FRZANCNFSM4HWVG6JA> .

[mikehardy]

Looks good to me :-). Yeah, I've seen flaky behavior in the past from time to time but I'm fairly sure the current codebase is pretty squeaky clean. Only saying that in case it helps you search for root cause, though of course software is always surprising so I won't say 100% certain. Either way, we're green again, I'm going to merge this