-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
NF: Gesture refactor to allow for mappable gestures #9142
Merged
mikehardy
merged 3 commits into
ankidroid:master
from
david-allison:6052-further-gesture-refactor
Jun 25, 2021
Merged
NF: Gesture refactor to allow for mappable gestures #9142
mikehardy
merged 3 commits into
ankidroid:master
from
david-allison:6052-further-gesture-refactor
Jun 25, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This exists because a good PR was proposed, but was not split up Add "isBound/isEnabled" Also adds tests Refactor towards 6052
mikehardy
approved these changes
Jun 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - this will be an interesting feature for 2.16 (more general mapping, and support for more peripherals, as this all lands, yes)
This doesn't look right?
|
We want to move from "gesture" -> "command" to "command" -> [gestures] to allow for arbitrary gesture mapping Moving to an enum allows more flexibility as a command becomes a first-class concern Refactoring towards issue 6052 Using 8078 as a guide
Gets closer to fixing 6052
125850f
to
d825cab
Compare
Gah, sorry. Missed the |
All clean and passes this time ⚡ |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose / Description
#8078 contains a large refactor to our gesture processing which allows arbitrary mapping of key inputs to commands
Currently, we map from Gesture -> Command
And we want to map from
Command -> [Gesture]
after the linked PR is completedThis brings the code closer to this PR, in a series of non-functional commits
The aim is that this change is fairly trivially reviewable, so we get closer to the idea
EDIT: Ref: #6052 (link is out of order)
How Has This Been Tested?
Unit tested
Checklist
if
statements)