-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
implement serde for Key Binding #9198
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
david-allison
commented
Jul 4, 2021
8c410fc
to
713554a
Compare
713554a
to
25de599
Compare
david-allison
commented
Jul 9, 2021
For serialisation to preferences From PR 8078 for 6052
25de599
to
0fadbc4
Compare
Unit test failure looks legit ?
|
For deserialization to preferences From PR 8078 for 6052
0fadbc4
to
8506926
Compare
mikehardy
approved these changes
Jul 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Also, because of this I learned of Rust "traits" via lookup of "what is serde" and seeing serde.rs 🤓
modem = modulator-demodulator |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request template
Purpose / Description
Key Bindings need to be serialized and deserialized from preferences
This brings in the code for #8078 to handle this aspect of #6052
How Has This Been Tested?
Should be non-functional, unit tests lifted from the PR
Checklist
if
statements)