feat: Customizable keyboard/gamepad shortcut preferences

[david-allison]

Pull Request template

Purpose / Description

People disagree on the keyboard shortcuts to use, let them customise them

Fixes

Fixes #6052

Approach

• Convert Volume gestures to keyboard gestures
• Add "Controls" section to preferences
• Controls can be mapped to front/back/both

How Has This Been Tested?

My Android 11 for a few weeks with a game controller, tested on API 21 and 23 briefly (screenshots from API 23)

Learning

• Keyboard Unicode symbol not available on API 21 and 22

Checklist

• You have not changed whitespace unnecessarily (it makes diffs hard to read)
• You have a descriptive commit message with a short title (first line, max 50 chars).
• Your code follows the style of the project (e.g. never omit braces in if statements)
• You have commented your code, particularly in hard-to-understand areas
• You have performed a self-review of your own code
• UI changes: include screenshots of all affected screens (in particular showing any new or changed strings)
• UI Changes: You have tested your change using the Google Accessibility Scanner
  • Doesn't like the default preference title/back button contrast with light blue

[mikehardy]

took a conflict but I'm about to roll through the commits right now

Keyboard Unicode symbol not available on API 21 and 22

Oh that sounds like fun

[mikehardy]

This all looks great - my solitary comment was about what looks like a duplicated build.gradle dep, and there is/was a conflict so needs a rebase

[david-allison]

This needs some CI testing as well before a merge - tests may be flaky.

EDIT: Bad de-conflict

[david-allison]

com.ichi2.anki.servicemodel.UpgradeVolumeButtonsToBindingsTest > if_mapped_to_non_empty_binding_then_added_to_end[0: isValid(TestData(affectedPreferenceKey=gestureVolumeUp, keyCode=24, unaffectedPreferenceKey=gestureVolumeDown, binding=com.ichi2.anki.reviewer.MappableBinding@1900db))={1}] FAILED
    java.util.ConcurrentModificationException
        at java.base/java.util.HashMap$HashIterator.nextNode(HashMap.java:1493)
        at java.base/java.util.HashMap$EntryIterator.next(HashMap.java:1526)
        at java.base/java.util.HashMap$EntryIterator.next(HashMap.java:1524)
        at com.android.internal.util.XmlUtils.writeMapXml(XmlUtils.java:299)
        at com.android.internal.util.XmlUtils.writeMapXml(XmlUtils.java:269)
        at com.android.internal.util.XmlUtils.writeMapXml(XmlUtils.java:235)
        at com.android.internal.util.XmlUtils.writeMapXml(XmlUtils.java:192)
        at android.app.SharedPreferencesImpl.writeToFile(SharedPreferencesImpl.java:773)
        at android.app.SharedPreferencesImpl.access$900(SharedPreferencesImpl.java:54)
        at android.app.SharedPreferencesImpl$2.run(SharedPreferencesImpl.java:642)
        at android.app.QueuedWork.processPendingWork(QueuedWork.java:258)
        at android.app.QueuedWork.waitToFinish(QueuedWork.java:172)
        at org.robolectric.shadows.ShadowSharedPreferences$ShadowSharedPreferencesEditorImpl.apply(ShadowSharedPreferences.java:25)
        at android.app.SharedPreferencesImpl$EditorImpl.apply(SharedPreferencesImpl.java)
        at com.ichi2.anki.servicelayer.PreferenceUpgradeService$PreferenceUpgrade$UpgradeVolumeButtonsToBindings.upgradeVolumeGestureToKeyBind$AnkiDroid_playDebug(PreferenceUpgradeService.kt:230)
        at com.ichi2.anki.servicelayer.PreferenceUpgradeService$PreferenceUpgrade$UpgradeVolumeButtonsToBindings.upgrade(PreferenceUpgradeService.kt:167)
        at com.ichi2.anki.servicelayer.PreferenceUpgradeService$PreferenceUpgrade.performUpgrade(PreferenceUpgradeService.kt:212)
        at com.ichi2.anki.servicemodel.UpgradeVolumeButtonsToBindingsTest.upgradeAllGestures(UpgradeVolumeButtonsToBindingsTest.kt:196)
        at com.ichi2.anki.servicemodel.UpgradeVolumeButtonsToBindingsTest.if_mapped_to_non_empty_binding_then_added_to_end(UpgradeVolumeButtonsToBindingsTest.kt:125)

Writing a preference should be threadsafe (unless from a different process). Unsure what's going on here, but needs looking into

EDIT: Hoping this is a Mockito spy issue. Spy has been removed.

[david-allison]

I'm doing a few close/reopens to ensure that unit tests aren't flaky

[mikehardy]

A series of green: https://github.com/ankidroid/Anki-Android/actions?query=branch%3A6052-new-prefs
build.gradle no longer has a duped dep, all looks good