Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Change order of name and state_file in command #19

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

PolonaM
Copy link
Contributor

@PolonaM PolonaM commented Dec 8, 2022

SUMMARY

In the outputs_command "name" and "-state" parameters needed to be swaped, to be able to get the desired value in case if both parameters are provided.

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

terraform_output module

@PolonaM PolonaM requested a review from sstanovnik December 8, 2022 07:37
@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Merging #19 (e391db2) into main (e391db2) will not change coverage.
The diff coverage is n/a.

❗ Current head e391db2 differs from pull request most recent head 3904ac4. Consider uploading reports for the commit 3904ac4 to get more accurate results

@@           Coverage Diff           @@
##             main      #19   +/-   ##
=======================================
  Coverage   63.93%   63.93%           
=======================================
  Files           8        8           
  Lines         513      513           
  Branches      118      118           
=======================================
  Hits          328      328           
  Misses        129      129           
  Partials       56       56           
Flag Coverage Δ
integration 69.15% <0.00%> (ø)
sanity 17.91% <0.00%> (ø)
units 20.51% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@softwarefactory-project-zuul
Copy link

Build failed.

✔️ build-ansible-collection SUCCESS in 3m 10s
ansible-test-sanity-docker-devel FAILURE in 9m 27s (non-voting)
ansible-test-sanity-docker-milestone FAILURE in 6m 36s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 6m 44s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 6m 39s
✔️ ansible-test-units-cloud-terraform-python38 SUCCESS in 5m 17s
ansible-test-changelog FAILURE in 2m 56s
✔️ ansible-galaxy-importer SUCCESS in 4m 28s

@softwarefactory-project-zuul
Copy link

Build succeeded.

✔️ build-ansible-collection SUCCESS in 3m 13s
ansible-test-sanity-docker-devel FAILURE in 6m 33s (non-voting)
ansible-test-sanity-docker-milestone FAILURE in 6m 34s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 7m 10s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 9m 25s
✔️ ansible-test-units-cloud-terraform-python38 SUCCESS in 5m 50s
✔️ ansible-test-changelog SUCCESS in 2m 14s
✔️ ansible-galaxy-importer SUCCESS in 4m 10s

Allows using state_file and a variable name simultaneously.
@sstanovnik sstanovnik force-pushed the terraform_output_fix_issue branch from fdd549a to 3904ac4 Compare December 12, 2022 05:51
Copy link
Contributor

@sstanovnik sstanovnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I've made some stylistic and wording changes myself, and the fix looks good.

@softwarefactory-project-zuul
Copy link

Build succeeded.

✔️ build-ansible-collection SUCCESS in 3m 12s
ansible-test-sanity-docker-devel FAILURE in 14m 00s (non-voting)
ansible-test-sanity-docker-milestone FAILURE in 6m 46s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 10m 58s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 10m 37s
✔️ ansible-test-units-cloud-terraform-python38 SUCCESS in 5m 09s
✔️ ansible-test-changelog SUCCESS in 2m 07s
✔️ ansible-galaxy-importer SUCCESS in 4m 12s

@sstanovnik sstanovnik merged commit 936705b into main Dec 12, 2022
@sstanovnik sstanovnik deleted the terraform_output_fix_issue branch December 12, 2022 06:16
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants