Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

meta/runtime.yml requires_ansible drop the space (#8) #9

Conversation

gravesm
Copy link
Member

@gravesm gravesm commented Nov 28, 2022

SUMMARY

meta/runtime.yml requires_ansible drop the space

This was triggering the following error:
plugins/module_utils/version.py:19:9: F401 'distutils.version.LooseVersion' imported but unused Import Task "23904" failed: 'requires_ansible' is not a valid semantic_version requirement specification

Reviewed-by: Mike Graves mgraves@redhat.com
(cherry picked from commit f9e0113)

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME
ADDITIONAL INFORMATION

meta/runtime.yml requires_ansible drop the space

This was triggering the following error:
plugins/module_utils/version.py:19:9: F401 'distutils.version.LooseVersion' imported but unused 
Import Task "23904" failed: 'requires_ansible' is not a valid semantic_version requirement specification 

Reviewed-by: Mike Graves <mgraves@redhat.com>
(cherry picked from commit f9e0113)
@codecov
Copy link

codecov bot commented Nov 28, 2022

Codecov Report

Merging #9 (8937ddc) into stable-1.0 (d4507e9) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           stable-1.0       #9   +/-   ##
===========================================
  Coverage       59.55%   59.55%           
===========================================
  Files               7        7           
  Lines             403      403           
  Branches           93       93           
===========================================
  Hits              240      240           
  Misses            119      119           
  Partials           44       44           
Flag Coverage Δ
integration 65.06% <ø> (ø)
sanity 17.12% <ø> (ø)
units 22.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@softwarefactory-project-zuul
Copy link

Build succeeded.

✔️ build-ansible-collection SUCCESS in 3m 08s
ansible-test-sanity-docker-devel FAILURE in 7m 56s (non-voting)
ansible-test-sanity-docker-milestone FAILURE in 6m 24s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 6m 29s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 6m 34s
✔️ ansible-test-units-cloud-terraform-python38 SUCCESS in 5m 11s
ansible-galaxy-importer FAILURE in 4m 23s (non-voting)

@softwarefactory-project-zuul
Copy link

Build succeeded (gate pipeline).

✔️ build-ansible-collection SUCCESS in 3m 11s
ansible-test-sanity-docker-devel FAILURE in 8m 34s (non-voting)
ansible-test-sanity-docker-milestone FAILURE in 7m 27s (non-voting)
✔️ ansible-test-sanity-docker-stable-2.13 SUCCESS in 6m 59s
✔️ ansible-test-sanity-docker-stable-2.14 SUCCESS in 8m 50s
✔️ ansible-test-units-cloud-terraform-python38 SUCCESS in 5m 22s
✔️ ansible-galaxy-importer SUCCESS in 4m 29s (non-voting)

@softwarefactory-project-zuul softwarefactory-project-zuul bot merged commit a92b52e into ansible-collections:stable-1.0 Nov 28, 2022
@gravesm gravesm deleted the backport/1.x/8 branch May 9, 2023 15:37
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants