Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Use atomic way of acquiring database lock #176

Merged
merged 1 commit into from
Oct 30, 2019
Merged

Use atomic way of acquiring database lock #176

merged 1 commit into from
Oct 30, 2019

Conversation

kmehant
Copy link
Member

@kmehant kmehant commented Oct 26, 2019 •
edited
Loading

Issue:

Fixes #47

Changes:

When there is a race condition, where multiple processes try to create a lock file then only one process should obtain and others should be pulled back to the waiting area.

@ansible-zuul
Copy link
Contributor

ansible-zuul bot commented Oct 26, 2019

Build succeeded.

@kmehant kmehant mentioned this pull request Oct 26, 2019
Closed
@kmehant
Copy link
Member Author

kmehant commented Oct 26, 2019

@TomasTomecek Please review!

TomasTomecek
TomasTomecek approved these changes Oct 30, 2019
View reviewed changes
Copy link
Collaborator

@TomasTomecek TomasTomecek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, all tests are passing and this is exactly what I had in mind.

@TomasTomecek TomasTomecek merged commit 71297ca into ansible-community:master Oct 30, 2019
@kmehant kmehant deleted the atomic-lock branch October 30, 2019 16:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@TomasTomecek TomasTomecek TomasTomecek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use atomic way of acquiring database lock
2 participants
@kmehant @TomasTomecek