Install submodules. #224
Merged
Install submodules. #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
honestly, it's been years since I used |
setup.cfg
Outdated
| @@ -31,7 +31,7 @@ keywords = | |||
|
|
|||
| [options] | |||
| python_requires = >=3.6 | |||
| packages = ansible_bender | |||
| packages = ansible_bender, ansible_bender.builders, ansible_bender.callback_plugins | |||
There was a problem hiding this comment.
I took look in the python packages docs and found this:
packages = find:
https://setuptools.readthedocs.io/en/latest/setuptools.html#configuring-setup-using-setup-cfg-files
could we try that instead?
There was a problem hiding this comment.
That also works.
I might be missing something... what I mean is, how did you build the wheel that pip installed? |
|
probably with python3 setup.py sdist |
TomasTomecek
approved these changes
May 13, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I see the the builders and callback plugins are included in the wheel, but they aren't installed by "python3 setup.py install". I think they need to be added to the packages list in setup.cfg, but I'm curious how the wheel was built, so that they were included.