Don't quote strings that start with 0 when running ansible-lint --fix. #4167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kousu
requested review from
Qalthos and
shatakshiiii
and removed request for
a team
kousu
force-pushed
the
protect-leading-0-str
branch
from
4d71bbe to
8add53b
Compare
kousu
force-pushed
the
protect-leading-0-str
branch
from
8add53b to
7ff873e
Compare
kousu
force-pushed
the
protect-leading-0-str
branch
from
7ff873e to
55eeb05
Compare
In order to try to handle [the mess that are octals in YAML](ansible#2965), some [special-case code was added](ansible#3030) to handle leading-zeros. But it caught too much, and would force quotes strings like on 00-header and 0.0.0.0, even when .yamllint doesn't require them: ``` quoted-strings: required: false ``` and it generates awkward lists, like ```diff loop: - "00-header" - 10-help-text - 50-landscape-sysinfo - 50-motd-news - 88-esm-announce - 97-overlayroot ```
kousu
force-pushed
the
protect-leading-0-str
branch
from
55eeb05 to
0dd5552
Compare
ssbarnea
approved these changes
May 24, 2024
|
Thank you for the merge @ssbarnea ! |
kousu
added a commit
to kousu/ansible-lint
that referenced
this pull request
Jun 20, 2024
I left a stray thought in ansible#4167. Sorry about that!
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to try to handle the mess that are octals in YAML, some special-case code was added to handle leading-zeros. But it caught too much, and would quote strings like
00-headerand0.0.0.0, even when .yamllint doesn't require them:and it generates awkward lists, like
loop: - "00-header" - 10-help-text - 50-landscape-sysinfo - 50-motd-news - 88-esm-announce - 97-overlayrootFixes #4166