Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4349
We're misusing
Path.open()
to look like we're using pathlib when we're effectively callingopen(sarif_file)
with more steps. The problem is that somewhere, sarif_file is getting picked up asAnsibleUnicode
, which passes throughPath.open
when provided in place of the path object, but not in Python 3.10, wherePath.open()
is less straightforward in its implementation.This fixes the issue, but does not solve the underlying problem, which is that
Options.sarif_file
is typed as a Path, but appears to take the value of a string. Either Options needs to be fixed to return this as a Path or the type should be fixed.The change from
open() -> write()
towrite_text()
is not strictly related but looks a lot cleaner and forces the inconsistent usage to be an error.