Replaces os.mknod with portable equivalent #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
os.mknod is not available to users on Mac OS. os.mknod causes two tests to fail: test_cmdline_playbook and test_cmdline_playbook_hosts. Replacing os.mknod with os.open and setting permissions on create in one step preserves security, makes the code portable, and makes the test pass.
|
This seems to fix #72 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
os.mknod is not available to users on Mac OS. os.mknod causes two tests
to fail: test_cmdline_playbook and test_cmdline_playbook_hosts.
Replacing os.mknod with os.open and setting permissions on create in one
step preserves security, makes the code portable, and makes the
test pass.