Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Strip no log values from module response keys #69653

Merged
merged 1 commit into from
May 21, 2020
Merged

Strip no log values from module response keys #69653

merged 1 commit into from
May 21, 2020

Conversation

sivel
Copy link
Member

@sivel sivel commented May 21, 2020

SUMMARY

Strip no log values from module response keys. Fixes #68400

ISSUE TYPE
  • Bugfix Pull Request
COMPONENT NAME

lib/ansible/module_utils/basic.py

ADDITIONAL INFORMATION

@ansibot ansibot added affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. core_review In order to be merged, this PR must follow the core review workflow. needs_triage Needs a first human triage before being processed. net_tools Net-tools category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team. labels May 21, 2020
@samdoran samdoran removed the needs_triage Needs a first human triage before being processed. label May 21, 2020
@samdoran samdoran self-requested a review May 21, 2020 19:29
@ansibot ansibot added needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. and removed core_review In order to be merged, this PR must follow the core review workflow. labels May 21, 2020
@samdoran samdoran merged commit e0f25a2 into ansible:devel May 21, 2020
@samdoran
Copy link
Contributor

This may be considered critical and worth backporting to 2.7 and 2.8 as well as 2.9.

@ansible ansible locked and limited conversation to collaborators Jun 18, 2020
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers

@samdoran samdoran samdoran approved these changes

Assignees
No one assigned
Labels
affects_2.10 This issue/PR affects Ansible v2.10 bug This issue/PR relates to a bug. needs_revision This PR fails CI tests or a maintainer has requested a review/revision of the PR. net_tools Net-tools category support:community This issue/PR relates to code supported by the Ansible community. support:core This issue/PR relates to code supported by the Ansible Engineering Team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

uri module set string with masked content into content and json output
3 participants
@sivel @samdoran @ansibot