Add support for mesh ingress #14640

fosterseth · 2023-11-06T23:26:38Z

SUMMARY

API changes to support mesh ingress (in-cluster hop node).

Notable changes:

adds ReceptorAddress model and related endpoints to the API
adds managed field to instance
InstanceLink peering is now from Instance to ReceptorAddress (before it was Instance to Instance)
UI changes to support the above peering changes, including a new Endpoints tab on the Instance detail page

ISSUE TYPE

New or Enhanced Feature

COMPONENT NAME

API
UI
Collection

awx/main/migrations/0188_inbound_hop_nodes.py

awx/main/models/ha.py

awx/main/models/receptor_address.py

awx/main/models/ha.py

awx/api/views/__init__.py

awx/main/models/ha.py

awx/main/models/receptor_address.py

awx/api/serializers.py

awx/main/management/commands/register_peers.py

awx/main/migrations/0188_inbound_hop_nodes.py

awx/main/models/receptor_address.py

This release supports ingress hop node, and is backwards compatible with previous AWX version. Signed-off-by: Seth Foster <fosterbseth@gmail.com>

Adds validation and a unit test to ensure: - peers_from_control_nodes=True should fail if listener_port is not set - peers_from_control_nodes=False should be NOOP if listener_port is not set Signed-off-by: Seth Foster <fosterbseth@gmail.com>

…nodes If the port is explicitly set to null (causing any ReceptorAddress to be deleted), then that's a validation error. If the port is left off but a ReceptorAddress doesn't already exist, we should not infer a port number and that is also a validation error.

so we don't need complex logic to compare an incoming to existing value.

Gives a bit more readability.

Since the relationship is ReceptorAddress -> Instance, prefetch_related isn't necessary.

and reuse information.

and all of the cases that they might be in.

Add functional test case for inspecting established receptor connections. InstanceLink starts in ADDING state, and should move to ESTABLISHED state if the connection is detected in the receptor status output. Signed-off-by: Seth Foster <fosterbseth@gmail.com>

Adds validation to prevent changing peers_from_control_nodes if instance managed=True Signed-off-by: Seth Foster <fosterbseth@gmail.com>

test_listener_port test_peers_from_control_nodes test_peers_from_control_nodes_without_listener_port are covered in the following tests: test_no_op test_creates_canonical_address test_deletes_canonical_address test_updates_canonical_address test_canonical_address_validation_error Signed-off-by: Seth Foster <fosterbseth@gmail.com>

In receptor address post-save method: - Fixed detecting if address was missing a link from control nodes - Use InstanceLink create_or_update to prevent adding duplicate InstanceLink source and target peers In instance serializer create_or_update, delete receptor addresses first before doing instance create or update. This ensures that we don't trigger unnecessary post-save methods that might attempt to manipulate receptor addresses that will just be removed later. Signed-off-by: Seth Foster <fosterbseth@gmail.com>

Make protocol be blank on instance if there is no canonical address for this instance. It was defaulting to "tcp" before. Signed-off-by: Seth Foster <fosterbseth@gmail.com>

Signed-off-by: Seth Foster <fosterbseth@gmail.com>

Also, update ui screen tests to expect injecting "listener_port: null" if listener_port is empty Signed-off-by: Seth Foster <fosterbseth@gmail.com>

Prevent creating InstanceLinks with duplicate source and target pairings. Signed-off-by: Seth Foster <fosterbseth@gmail.com>

Listener Addresses is a better name to emphasize these are routable addresses to reach a listener service on the node. Also removed expand toggle on the listener addresses list items, as the expanded mode had no additional information. Signed-off-by: Seth Foster <fosterbseth@gmail.com>

github-actions bot added the component:api label Nov 6, 2023