-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Add Github dep for new cred support if used #15850
Conversation
* fixed git requirements file with new * added new github dep and relevant deps it needs
API test failure
|
Seems that the schema reference got blown away.
For right now, I wouldn't worry about it much. The api-schema check. |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thedoubl3j it's 2.6.1 in awx-plugins
@@ -45,6 +45,7 @@ prometheus_client | |||
psycopg | |||
psutil | |||
pygerduty | |||
PyGithub <= 2.6.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@thedoubl3j it's a transitive dep. Isn't this file supposed to list direct deps? The correct thing to do would be to depend on awx-plugins-core [credentials-github-app]
that declares the dependency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are correct. Put up #15853
I was a bit panicked to merge this PR yesterday, because it was breaking checks and presumably the installs. If we have an outright missing dependency, I'd hope that we could ignore all checks and force it through. After that, fine to do cleanup.
The way this is a floating dependency on awx-plugins-core, honestly, our best-case scenario would have been to add it to requirements.in
a day before merging the plugins patch. Then merge the plugins patch, then update the requirements. Otherwise - pin the plugins version.
fixed git requirements file with new line so dep compiler can run and added new github dep and relevant deps it needs
SUMMARY
ISSUE TYPE
COMPONENT NAME
AWX VERSION
ADDITIONAL INFORMATION