Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add Github dep for new cred support if used #15850

Merged
merged 5 commits into from
Feb 20, 2025

Conversation

thedoubl3j
Copy link
Member

fixed git requirements file with new line so dep compiler can run and added new github dep and relevant deps it needs

SUMMARY
ISSUE TYPE
  • Bug, Docs Fix or other nominal change
COMPONENT NAME
  • Other
AWX VERSION
devel
ADDITIONAL INFORMATION

* fixed git requirements file with new
* added new github dep and relevant deps it needs
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Feb 20, 2025
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.88%. Comparing base (bf4d454) to head (5d167b6).
Report is 1 commits behind head on devel.

✅ All tests successful. No failed tests found.

@AlanCoding
Copy link
Member

API test failure

Exception: Included licenses not consistent with requirements:
 license for requirement pygithub is missing
 license for requirement pynacl is missing

@thedoubl3j thedoubl3j enabled auto-merge (squash) February 20, 2025 20:20
@AlanCoding
Copy link
Member

Seems that the schema reference got blown away.

2025-02-20T20:26:59.1446957Z diff -u -b reference-schema.json schema.json
2025-02-20T20:26:59.2183079Z --- reference-schema.json	2025-02-20 20:26:59.140367865 +0000
2025-02-20T20:26:59.2183769Z +++ schema.json	2025-02-20 20:26:49.290396558 +0000
2025-02-20T20:26:59.2184236Z @@ -1,2 +1,41679 @@
2025-02-20T20:26:59.2184606Z -<?xml version="1.0" encoding="UTF-8"?>
2025-02-20T20:26:59.2186511Z -<Error><Code>NoSuchKey</Code><Message>The specified key does not exist.</Message><Key>devel/schema.json</Key><RequestId>D74G2SX3Z70CD6HQ</RequestId><HostId>6pT9m7AKYF7uj29ilNsaSP1OLhR0gImp8Q/vUZGAHjcmEhe7nFXujEya5wcZm944+5+AbDLhnmU=</HostId></Error>

For right now, I wouldn't worry about it much. The api-schema check.

@thedoubl3j thedoubl3j merged commit fa099fe into ansible:devel Feb 20, 2025
18 of 19 checks passed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thedoubl3j it's 2.6.1 in awx-plugins

@@ -45,6 +45,7 @@ prometheus_client
psycopg
psutil
pygerduty
PyGithub <= 2.6.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thedoubl3j it's a transitive dep. Isn't this file supposed to list direct deps? The correct thing to do would be to depend on awx-plugins-core [credentials-github-app] that declares the dependency.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct. Put up #15853

I was a bit panicked to merge this PR yesterday, because it was breaking checks and presumably the installs. If we have an outright missing dependency, I'd hope that we could ignore all checks and force it through. After that, fine to do cleanup.

The way this is a floating dependency on awx-plugins-core, honestly, our best-case scenario would have been to add it to requirements.in a day before merging the plugins patch. Then merge the plugins patch, then update the requirements. Otherwise - pin the plugins version.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
component:api dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants