Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Hide token generated by "Get token" tasks #444

Open
wants to merge 9 commits into
base: devel
Choose a base branch
from
Open

Conversation

w4hf
Copy link

@w4hf w4hf commented Feb 5, 2025

What does this PR do?

Use the existing ah_configuration_*_secure_logging variables to give the possibility to hide the generated token

Added no_log: "{{ ah_configuration_X_secure_logging }}" to every Get Token task
Created a new variable ah_configuration_offline_sync_secure_logging for the offline_sync role

How should this be tested?

Set ah_configuration_X_secure_logging of a role which has a Get Token task to true and see that the authentication token is now hidden in the output of the task Get Token

Is there a relevant Issue open for this?

N/A

Other Relevant info, PRs, etc

The code in this repo is often used in pipelines where the job log is public.
It is a good practice to hide the token which usually have superadmin role.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant