Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Avoid accidental plugin activation #202

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Avoid accidental plugin activation #202

merged 1 commit into from
Oct 27, 2023

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented Oct 20, 2023

Fixes a bug where a randomly named fixture caused plugin activation even if the project would not make any use of pytest-ansible, causing a runtime error due to the assertion of missing arguments.

This affected ansible-lint project.

Fixes: #196

@ssbarnea ssbarnea requested a review from a team as a code owner October 20, 2023 11:24
@ssbarnea ssbarnea requested review from priyamsahoo and shatakshiiii and removed request for a team October 20, 2023 11:24
@ssbarnea ssbarnea temporarily deployed to ack October 20, 2023 11:24 — with GitHub Actions Inactive
@ssbarnea ssbarnea added the bug label Oct 20, 2023
@ssbarnea ssbarnea temporarily deployed to ack October 20, 2023 11:24 — with GitHub Actions Inactive
@ssbarnea ssbarnea requested a review from cidrblock October 20, 2023 11:24
@ssbarnea ssbarnea temporarily deployed to test October 20, 2023 11:24 — with GitHub Actions Inactive
@ssbarnea ssbarnea temporarily deployed to test October 20, 2023 11:24 — with GitHub Actions Inactive
@ssbarnea ssbarnea temporarily deployed to test October 20, 2023 11:24 — with GitHub Actions Inactive
@ssbarnea ssbarnea changed the title Avoid plugin misaactivation with random ansible_ prefixed fixtures Avoid accidental plugin activation Oct 20, 2023
@ssbarnea ssbarnea temporarily deployed to ack October 20, 2023 15:22 — with GitHub Actions Inactive
@ssbarnea ssbarnea temporarily deployed to test October 20, 2023 15:22 — with GitHub Actions Inactive
@ssbarnea ssbarnea temporarily deployed to test October 20, 2023 15:22 — with GitHub Actions Inactive
@ssbarnea ssbarnea temporarily deployed to test October 20, 2023 15:22 — with GitHub Actions Inactive
@ssbarnea ssbarnea temporarily deployed to ack October 27, 2023 11:50 — with GitHub Actions Inactive
@pre-commit-ci pre-commit-ci bot temporarily deployed to ack October 27, 2023 11:50 Inactive
@pre-commit-ci pre-commit-ci bot temporarily deployed to test October 27, 2023 11:51 Inactive
@pre-commit-ci pre-commit-ci bot temporarily deployed to test October 27, 2023 11:51 Inactive
@pre-commit-ci pre-commit-ci bot temporarily deployed to test October 27, 2023 11:51 Inactive
Fixes a bug where a randomly named fixture caused plugin activation
even if the project would not make any use of pytest-ansible, causing
a runtime error due to the assertion of missing arguments.
@ssbarnea ssbarnea temporarily deployed to ack October 27, 2023 12:07 — with GitHub Actions Inactive
@ssbarnea ssbarnea temporarily deployed to test October 27, 2023 12:08 — with GitHub Actions Inactive
@ssbarnea ssbarnea temporarily deployed to test October 27, 2023 12:08 — with GitHub Actions Inactive
@ssbarnea ssbarnea temporarily deployed to test October 27, 2023 12:08 — with GitHub Actions Inactive
@ssbarnea ssbarnea temporarily deployed to test October 27, 2023 12:08 — with GitHub Actions Inactive
@ssbarnea ssbarnea temporarily deployed to test October 27, 2023 12:08 — with GitHub Actions Inactive
@ssbarnea ssbarnea temporarily deployed to test October 27, 2023 12:08 — with GitHub Actions Inactive
@ssbarnea ssbarnea temporarily deployed to test October 27, 2023 12:08 — with GitHub Actions Inactive
@ssbarnea ssbarnea temporarily deployed to test October 27, 2023 12:08 — with GitHub Actions Inactive
@ssbarnea ssbarnea merged commit 1518c54 into main Oct 27, 2023
@ssbarnea ssbarnea deleted the fix/support branch October 27, 2023 12:16
ssbarnea added a commit that referenced this pull request Oct 27, 2023
This fixed a bug where console redirection made by molecule affected
pytest execution by adding one new extra newline at each test.

Also this removes use of a deprecated function from molecule.
ssbarnea added a commit that referenced this pull request Oct 28, 2023
This fixed a bug where console redirection made by molecule affected
pytest execution by adding one new extra newline at each test.

Also this removes use of a deprecated function from molecule.
ssbarnea added a commit that referenced this pull request Oct 28, 2023
This fixed a bug where console redirection made by molecule affected
pytest execution by adding one new extra newline at each test.

Also this removes use of a deprecated function from molecule.
ssbarnea added a commit that referenced this pull request Oct 28, 2023
…#210)

This fixed a bug where console redirection made by molecule affected
pytest execution by adding one new extra newline at each test.

Also this removes use of a deprecated function from molecule.
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

ERROR: Missing required parameter --ansible-host-pattern/--host-pattern
3 participants