Skip to content

Adding latest changes from mapdl.math #109

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 11 commits into from
Jun 12, 2023
Merged

Adding latest changes from mapdl.math #109

merged 11 commits into from
Jun 12, 2023

Conversation

clatapie
Copy link
Collaborator

@clatapie clatapie commented Jun 5, 2023

Closes #108.

@clatapie clatapie self-assigned this Jun 5, 2023
@clatapie clatapie linked an issue Jun 5, 2023 that may be closed by this pull request
Update the library #108
Closed
@github-actions github-actions bot added the maintenance Package and maintenance related label Jun 5, 2023
@clatapie clatapie requested review from RobPasMue and germa89 June 5, 2023 15:48
@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2023 •
edited
Loading

Codecov Report

Merging #109 (2598666) into main (4b9f310) will decrease coverage by 2.03%.
The diff coverage is 57.89%.

@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
- Coverage   92.71%   90.68%   -2.03%     
==========================================
  Files           2        2              
  Lines         549      580      +31     
==========================================
+ Hits          509      526      +17     
- Misses         40       54      +14

germa89
germa89 approved these changes Jun 7, 2023
View reviewed changes
Copy link
Collaborator

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this is just copy paste from PyMAPDL, then LGTM.

@clatapie
Copy link
Collaborator Author

clatapie commented Jun 9, 2023 •
edited
Loading

Codecov will be added to the checks in another PR.

@clatapie clatapie enabled auto-merge (squash) June 9, 2023 15:28
@clatapie clatapie merged commit e2998bc into main Jun 12, 2023
@clatapie clatapie deleted the maint/update branch June 12, 2023 11:02
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@germa89 germa89 germa89 approved these changes

@RobPasMue RobPasMue Awaiting requested review from RobPasMue

Assignees

@clatapie clatapie

Labels
maintenance Package and maintenance related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update the library
3 participants
@clatapie @codecov-commenter @germa89