Skip to content

MAINT: generic updates #70

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 21, 2023
Merged

MAINT: generic updates #70

merged 4 commits into from
Mar 21, 2023

Conversation

jorgepiloto
Copy link
Member

@jorgepiloto jorgepiloto commented Mar 21, 2023 •
edited
Loading

This pull-request introdues some minor maintenance to the project, including:

  • Updates the tox.ini by dropping py37 testing
  • Output HTML docs in doc/_build/html when using tox -e doc
  • Update some pre-commit hooks

@github-actions github-actions bot added the maintenance Package and maintenance related label Mar 21, 2023
@jorgepiloto
Copy link
Member Author

Some questions, @clatapie and @RobPasMue:

  • I see there is a Makefile at the root of the project dir. This file seems to focus on doc checks. It is not used anywhere in the CI/CD. Should it be removed?

  • About support for Pyhton 3.7. I guess you are planning to support 3.7 for this release but drop it for later releases.

@RobPasMue
Copy link
Member

That Makefile should be removed, indeed. Thanks for pointing it out @jorgepiloto
And yeah, Python 3.7 should be accepted in this release only. Once official support is dropped, we'll do the same here.

@jorgepiloto jorgepiloto marked this pull request as ready for review March 21, 2023 08:50
clatapie
clatapie approved these changes Mar 21, 2023
View reviewed changes
Copy link
Collaborator

@clatapie clatapie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with those changes! Thank you @jorgepiloto 👍

@RobPasMue RobPasMue merged commit e9d087a into main Mar 21, 2023
@RobPasMue RobPasMue deleted the maint/generic branch March 21, 2023 13:09
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@clatapie clatapie clatapie approved these changes

Assignees
No one assigned
Labels
maintenance Package and maintenance related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jorgepiloto @RobPasMue @clatapie