Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Remove motion in TreeSelect #21410

Merged
merged 1 commit into from
Feb 17, 2020
Merged

fix: Remove motion in TreeSelect #21410

merged 1 commit into from
Feb 17, 2020

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Feb 17, 2020

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / document update
  • Component style update
  • TypeScript definition update
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

fix #21395
fix #21362

💡 Background and solution

根源是 dom-align 重新 align 后导致游览器重绘跳过动画,使得动画的 finish 事件一直无法触发导致的页面不更新的问题。需要一个全新的基于 React 生命周期的 align 来根本 fix。暂时去除 TreeSelect 缩放的动画效果。

📝 Changelog

Language Changelog
🇺🇸 English Fix TreeSelect popup do not update issue.
🇨🇳 Chinese 修复 TreeSelect 弹出层不更新的问题。

☑️ Self Check before Merge

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@ant-design-bot
Copy link
Contributor

ant-design-bot commented Feb 17, 2020

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@codecov
Copy link

codecov bot commented Feb 17, 2020

Codecov Report

Merging #21410 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #21410   +/-   ##
=======================================
  Coverage   97.83%   97.83%           
=======================================
  Files         302      302           
  Lines        7007     7007           
  Branches     1884     1932   +48     
=======================================
  Hits         6855     6855           
  Misses        152      152
Impacted Files Coverage Δ
components/tree-select/index.tsx 97.72% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e39eba...c4a5d9c. Read the comment docs.

@zombieJ zombieJ merged commit 502d575 into master Feb 17, 2020
@zombieJ zombieJ deleted the fix-tree-select branch February 17, 2020 06:53
@pr-triage pr-triage bot added the PR: merged label Feb 17, 2020
@ycjcl868 ycjcl868 mentioned this pull request Feb 24, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TreeSelect 多次展开目录不显示下级目录 TreeSelect 的 loadDate 返回太快话,会出现问题
2 participants