fix: optimize the type definition of Modal #41742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #41742 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 614 614
Lines 10503 10502 -1
Branches 2876 2876
=========================================
- Hits 10503 10502 -1
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
afc163
reviewed
Apr 11, 2023
yoyo837
reviewed
Apr 12, 2023
afc163
reviewed
Apr 12, 2023
afc163
approved these changes
Apr 12, 2023
RedJue
pushed a commit
to RedJue/ant-design
that referenced
this pull request
Apr 25, 2023
* fix: optimize modal type * test: update test * test: update test * fix: funcModal do not support afterOPenChange * fix: funcModal do not support afterOPenChange1 * docs: use en exegesis * docs: use en exegesis
RedJue
pushed a commit
to RedJue/ant-design
that referenced
this pull request
Apr 25, 2023
* fix: optimize modal type * test: update test * test: update test * fix: funcModal do not support afterOPenChange * fix: funcModal do not support afterOPenChange1 * docs: use en exegesis * docs: use en exegesis
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
close #41735
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 58acf10
This pull request adds a new prop
afterOpenChangeto theModalandConfirmDialogcomponents, and tests its functionality. The prop allows users to specify a callback function that runs after the modal transition finishes.🔍 Walkthrough
🤖 Generated by Copilot at 58acf10
afterOpenChangeprop toModalandConfirmDialogcomponents, which is a function that is called after the modal animation ends when the modal is opened or closed (link, link, link).