Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: Badge dot with status #44153

Merged
merged 2 commits into from
Aug 10, 2023
Merged

fix: Badge dot with status #44153

merged 2 commits into from
Aug 10, 2023

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Aug 10, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

fix #43653

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Badge status="processing" with dot wave style issue.
🇨🇳 Chinese 修复 Badge status="processing"dot 配合使用时,波纹样式异常的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at a36b029

This pull request improves the badge component by adding a new demo example, fixing a dot overflow bug, and standardizing the color prop syntax.

🔍 Walkthrough

🤖 Generated by Copilot at a36b029

  • Fix a bug where the badge dot would be cut off by the parent element in some cases by adding an overflow: visible style to the badge with a status of processing (link)
  • Add a new example of using a badge with a dot and a status of processing on an avatar with a square shape and a large size in components/badge/demo/mix.tsx to demonstrate the customization of the badge component (link)
  • Fix the inconsistent use of single and double quotes for the color prop in the badge examples in components/badge/demo/mix.tsx to improve the code style and readability (link)

@stackblitz
Copy link

stackblitz bot commented Aug 10, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 10, 2023

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 386.95 KB (+7 B 🔺)
./dist/antd-with-locales.min.js 446.05 KB (+6 B 🔺)

@argos-ci
Copy link

argos-ci bot commented Aug 10, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 1 change Aug 10, 2023, 8:56 AM

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5af2dcc) 100.00% compared to head (a36b029) 100.00%.
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #44153   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          659       659           
  Lines        11200     11200           
  Branches      3033      3033           
=========================================
  Hits         11200     11200           
Files Changed Coverage Δ
components/badge/style/index.ts 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zombieJ zombieJ merged commit 54081c8 into master Aug 10, 2023
@zombieJ zombieJ deleted the fix-dot-badge branch August 10, 2023 09:10
@MadCcc MadCcc mentioned this pull request Aug 10, 2023
20 tasks
@PeachScript PeachScript mentioned this pull request Aug 11, 2023
20 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Badge 的 processing 状态用于角标时有样式错误
4 participants