style: fix Select baseline align bug #44927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
afc163
commented
Sep 18, 2023
| /* For undefined value baseline align */ | ||
| `${componentCls}-selection-placeholder:after`, | ||
| `${componentCls}-selection-placeholder:empty:after`, |
There was a problem hiding this comment.
在 components/input/demo/align.tsx 里补充了这两个样式的使用场景，发现只有 :empty 的时候是需要的。在其他情况下去掉可解决 #44907 的问题。
Closed
afc163
force-pushed
the
fix/select-wrap-style
branch
from
36e7a4a to
a717443
Compare
size-limit report 📦
|
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #44927 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 682 682
Lines 11540 11540
Branches 3105 3105
=========================================
Hits 11540 11540
☔ View full report in Codecov by Sentry. |
li-jia-nan
approved these changes
Sep 18, 2023
Yuiai01
reviewed
Sep 18, 2023
| </Select> | ||
| <Select style={{ width: 100 }} defaultValue="jack" options={selectOptions} /> | ||
| <Select style={{ width: 100 }} defaultValue="" options={selectOptions} /> | ||
| <Select style={{ width: 100 }} options={selectOptions} /> |
There was a problem hiding this comment.
增加一个覆盖这个对应问题的 demo，比如 {label: <div>Tes </div>, value: 'xxx'} 会不会好些。
There was a problem hiding this comment.
zombieJ
approved these changes
Sep 18, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
close #44907
ref antvis/L7VP#28
💡 Background and solution
📝 Changelog
labelcontainsdivelement.label内使用了div块级元素时的样式问题。☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 2f4e965
This pull request enhances the demos and fixes a bug related to the alignment of the
InputandSelectcomponents. It adds titles and more cases to thealigndemo of theInputcomponent, and improves theoption-label-centerdemo of theSelectcomponent. It also fixes the baseline alignment of the single style of theSelectcomponent when the value is empty or undefined.🔍 Walkthrough
🤖 Generated by Copilot at 2f4e965