Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: detect bun as package manager from bun.lock file #38

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

anurag-roy
Copy link
Contributor

Description

This PR adds a feature to detect bun as the package manager if bun.lock file is present

Linked Issues

Solves #37

@anurag-roy
Copy link
Contributor Author

Could anyone please help me with the tests?

I think there should be a test case where we check if bun is being inferred as a package manager when bun.lock file is present, just like we have a test case for bun.lockb.

But the way tests are setup currently, there's a folder for bun inside test/fixtures/lockfile which gets tested by traversing all the directories inside lockfile. So, I cannot just add a bun.lock file inside the bun folder. Should I create a new folder called bun-lock and pass it on here like

const agents = [...AGENTS, 'bun-lock', 'unknown']

@antfu
Copy link
Member

antfu commented Dec 17, 2024

To me I am fine with having this without tests as this change should be very straightforward

@anurag-roy
Copy link
Contributor Author

Can this be merged? @benmccann

@benmccann benmccann merged commit 799f5e7 into antfu-collective:main Dec 20, 2024
2 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants