Colin/agents-threaded-event-reader #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xJepsen
reviewed
Apr 5, 2023
No more async, arc, rwlock needed now.
It was not very clean at that point -- just working. I cleaned it up and it's looking good now. Opening PR now. |
|
Closes #153 |
|
I need to set up dispatching so messages aren't consumed on other threads. Working on this now. |
Manager also doesn't need a receiver.
|
I think this should close it. See the reworked test. |
0xJepsen
approved these changes
Apr 6, 2023
| let writer_base_contract_for_admin = writer.base_contract.clone(); | ||
| let admin_handle = thread::spawn(move || { | ||
| let mut i = 0; | ||
| while let Ok(logs) = reader_for_admin.recv() { |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to close #153.
Still need to build the functionality of actually awaiting new events. Trying to model this after ethers.