Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Improving upon contract interfaces #202

Merged
merged 7 commits into from
Apr 14, 2023
Merged

Improving upon contract interfaces #202

merged 7 commits into from
Apr 14, 2023

Conversation

Autoparallel
Copy link
Collaborator

@Autoparallel Autoparallel commented Apr 14, 2023 •
edited
Loading

  • Created a minimal implementation of SimulationMiddleware that will let us use the forge generated bindings for a nicer API.
  • Moved the SimulationContract struct and related items into the contract.rs module and out of environment.rs.
  • Got rid of the option for the address in the SimulationContract using types.

@Autoparallel Autoparallel requested a review from 0xJepsen April 14, 2023 07:47
@Autoparallel
Copy link
Collaborator Author

Clippy won't pass until we clean up the simulation price generator stuff.

0xJepsen
0xJepsen approved these changes Apr 14, 2023
View reviewed changes
Copy link
Collaborator

@0xJepsen 0xJepsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delicious!

@0xJepsen 0xJepsen merged commit 8536607 into main Apr 14, 2023
@0xJepsen 0xJepsen deleted the colin/testing-out-stuff-bruh branch May 8, 2023 09:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@0xJepsen 0xJepsen 0xJepsen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Autoparallel @0xJepsen