Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Colin/abstract main #220

Merged
merged 8 commits into from
Apr 24, 2023
Merged

Colin/abstract main #220

merged 8 commits into from
Apr 24, 2023

Conversation

Autoparallel
Copy link
Collaborator

@Autoparallel Autoparallel commented Apr 21, 2023 •
edited
Loading

  • Moves the logic for chain out of main.rs and into chain.rs.

Depends on #219 first as I was working ahead of that branch.

Closes #214

@Autoparallel Autoparallel requested a review from 0xJepsen April 21, 2023 13:18
@Autoparallel
Copy link
Collaborator Author

I did some more clean up around the repo. There were some redundancies and shorter ways to accomplish things. Most notably I created an onion type with the PriceProcessType so we have the data inside the enums. E.g., GBM(GBM).

@Autoparallel
Copy link
Collaborator Author

The last commit I renamed the Price struct to PriceProcess for a bit more clarity.

@Autoparallel Autoparallel marked this pull request as ready for review April 24, 2023 09:39
FiberedSkies
FiberedSkies approved these changes Apr 24, 2023
View reviewed changes
Copy link
Contributor

@FiberedSkies FiberedSkies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks all good!!

0xJepsen
0xJepsen approved these changes Apr 24, 2023
View reviewed changes
Copy link
Collaborator

@0xJepsen 0xJepsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@0xJepsen 0xJepsen merged commit 329a18c into main Apr 24, 2023
@0xJepsen 0xJepsen deleted the colin/abstract-main branch May 15, 2023 05:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@0xJepsen 0xJepsen 0xJepsen approved these changes

@FiberedSkies FiberedSkies FiberedSkies approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Abstract functionality out of main.
3 participants
@Autoparallel @0xJepsen @FiberedSkies