Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Waylon/versioning #224

Merged
merged 5 commits into from
Apr 26, 2023
Merged

Waylon/versioning #224

merged 5 commits into from
Apr 26, 2023

Conversation

0xJepsen
Copy link
Collaborator

Closes #223

@0xJepsen 0xJepsen marked this pull request as ready for review April 25, 2023 09:23
@0xJepsen 0xJepsen requested a review from Autoparallel April 25, 2023 09:23
Autoparallel
Autoparallel reviewed Apr 25, 2023
View reviewed changes
Copy link
Collaborator

@Autoparallel Autoparallel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't we wanting to bump the patch version not the minor version?

Major.Minor.Patch

Right?

Autoparallel
Autoparallel requested changes Apr 25, 2023
View reviewed changes
Copy link
Collaborator

@Autoparallel Autoparallel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit nervous to merge this at the moment as I'm not able to parse the logic completely. Where are we actually incrementing the patch version by 1? I know it's in lines 37-42, but I don't get it.

ankit-gautam23
ankit-gautam23 approved these changes Apr 26, 2023
View reviewed changes
Copy link

@ankit-gautam23 ankit-gautam23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xJepsen 0xJepsen requested a review from Autoparallel April 26, 2023 07:10
Autoparallel
Autoparallel approved these changes Apr 26, 2023
View reviewed changes
Copy link
Collaborator

@Autoparallel Autoparallel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Autoparallel Autoparallel merged commit 54ec850 into main Apr 26, 2023
@0xJepsen 0xJepsen deleted the waylon/versioning branch May 8, 2023 09:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Autoparallel Autoparallel Autoparallel approved these changes

@ankit-gautam23 ankit-gautam23 ankit-gautam23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automatic Versioning
3 participants
@0xJepsen @Autoparallel @ankit-gautam23