Colin/simple arb detection #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
time to fix the rest of the tests and clean up
|
Just fixed the conflicts. |
0xJepsen
approved these changes
Apr 29, 2023
| thread::spawn(move || { | ||
| while let Ok(_logs) = receiver.recv() { | ||
| // self.filter_events(logs); | ||
| let decoder = |input, filter_num: usize| { |
| @@ -151,23 +232,52 @@ pub struct SimulationEventFilter { | |||
| pub address: B160, | |||
| /// The event names to filter for. | |||
| pub topic: H256, | |||
| /// A private copy of the [`BaseContract`] for whichever contract is used to generate filters. | |||
| base_contract: BaseContract, | |||
There was a problem hiding this comment.
why does this need to be private?
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #144
Quite a big refactor was needed in order to give us the ability to have a struct like
SimpleArbitrageuran impl block that we can access from a simulation. That is, working with&dyn Agentcan't do this and it would have required a complicatedevent_monitoring()function to be created.This is now done by using the
AgentTypeenum which does create an onion type by virtue of items likeAgentType::User(User). This is not the most elegant, but we get more control this way.In order to make the creation of agents easier, we have a trait called
AgentStatusthat allows for fields of each agent struct to change depending on whether it has been added to theSimulationManager's HashMap as well as theSimulationEnvironmentdb. This also required a bit of finagling with another traitIdentifiablewhich solely retrieves the name of an agent.A new test was written in
simple_arbitrageur.rscalledsimple_arbitrage_detection(). Think of this as a basic boilerplate example of detecting price differences. It is rather clunky for now, but going further felt a bit silly until we have other pools to arb with.