Fixes issue #234

[MakisChristou]

I have added a slight modification to the install.sh to use the rust bin directory that is already created and added to the path automatically on Windows.

Closes #234

[Autoparallel]

I don't have a Windows machine to test this on personally. @0xEstelle or @Alexangelj can you give this a shot?

[Autoparallel]

I have added a slight modification to the install.sh to use the rust bin directory that is already created and added to the path automatically on Windows.

Hi @MakisChristou, I'm curious what you think about a slightly different approach. With cargo, we can instead do:

cargo install --path crates/cli --force

This will install the binary in
Users/$USER/.cargo/bin/arbiter
at least on MacOS.

From my experience, this also generates a symlink to arbiter.

This can still be put in an .install.sh script to make life a bit easier.

What do you think?

[MakisChristou]

Hello @Autoparallel. I have tried this (cargo install --path crates/cli --force) on both MacOs and Windows 11 and it looks like its working. So maybe we can just skip the install.sh script altogether? I don't see why its needed.

[Autoparallel]

Hello @Autoparallel. I have tried this (cargo install --path crates/cli --force) on both MacOs and Windows 11 and it looks like its working. So maybe we can just skip the install.sh script altogether? I don't see why its needed.

Seems reasonable. Perhaps a good way to give you credit through this work is to edit the README with these instructions?

[MakisChristou]

What about now?

[Autoparallel]

Perfect. I'll merge now.

[Autoparallel]

lgtm