Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Waylon/auto versioning #261

Merged
merged 14 commits into from
May 8, 2023
Merged

Waylon/auto versioning #261

merged 14 commits into from
May 8, 2023

Conversation

0xJepsen
Copy link
Collaborator

@0xJepsen 0xJepsen commented May 5, 2023

Closes #260

@0xJepsen 0xJepsen marked this pull request as ready for review May 5, 2023 07:18
@codecov-commenter
Copy link

codecov-commenter commented May 5, 2023 •
edited
Loading

Codecov Report

Merging #261 (63c7be0) into main (79bca03) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@          Coverage Diff          @@
##            main    #261   +/-   ##
=====================================
  Coverage   8.07%   8.07%           
=====================================
  Files         92      92           
  Lines      21688   21688           
=====================================
  Hits        1752    1752           
  Misses     19936   19936
Impacted Files Coverage Δ
crates/bindings/src/liquid_exchange.rs 1.09% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Autoparallel
Autoparallel previously requested changes May 5, 2023
View reviewed changes
Copy link
Collaborator

@Autoparallel Autoparallel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what the changes outside the yaml file are for. Otherwise, lgtm.

@0xJepsen
Copy link
Collaborator Author

0xJepsen commented May 5, 2023

I'm not sure what the changes outside the yaml file are for. Otherwise, lgtm.

They where just adding back the liquid exchange because of accidentally deleting them

@0xJepsen 0xJepsen requested a review from Autoparallel May 5, 2023 13:13
@0xJepsen 0xJepsen requested a review from FiberedSkies May 5, 2023 13:15
@0xJepsen
Copy link
Collaborator Author

0xJepsen commented May 5, 2023

Let me know what changes you want otherwise this should be good to go

FiberedSkies
FiberedSkies approved these changes May 7, 2023
View reviewed changes
Copy link
Contributor

@FiberedSkies FiberedSkies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! see you added the exchange contract and binding back!

@0xJepsen 0xJepsen dismissed Autoparallel’s stale review May 8, 2023 11:43

addressed changes

@FiberedSkies FiberedSkies merged commit a12e1a9 into main May 8, 2023
@0xJepsen 0xJepsen deleted the waylon/auto_versioning branch May 15, 2023 05:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@FiberedSkies FiberedSkies FiberedSkies approved these changes

@Autoparallel Autoparallel Awaiting requested review from Autoparallel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Auto Patch bumping isn't working
4 participants
@0xJepsen @codecov-commenter @Autoparallel @FiberedSkies