Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Waylon/subcommands #265

Merged
merged 10 commits into from
May 8, 2023
Merged

Waylon/subcommands #265

merged 10 commits into from
May 8, 2023

Conversation

0xJepsen
Copy link
Collaborator

@0xJepsen 0xJepsen commented May 8, 2023

Closes #246

Added two subcommands for sim
to use the portfolio subcommand use cargo run sim portfolio
to use the uniswap subcommand use cargo run sim uniswap

@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Merging #265 (668f33a) into main (94b7a79) will decrease coverage by 0.02%.
The diff coverage is 0.00%.

@@           Coverage Diff            @@
##            main    #265      +/-   ##
========================================
- Coverage   8.41%   8.39%   -0.02%     
========================================
  Files         93      94       +1     
  Lines      22161   22205      +44     
========================================
  Hits        1864    1864              
- Misses     20297   20341      +44     
Impacted Files Coverage Δ
crates/cli/src/main.rs 2.08% <0.00%> (-0.19%) ⬇️
crates/cli/src/sim/portfolio_sim.rs 49.04% <0.00%> (ø)
crates/cli/src/sim/uniswap_sim.rs 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@0xJepsen
Copy link
Collaborator Author

0xJepsen commented May 8, 2023

I'm really confused why the tests are failing. The pass when i run them locally.

@0xJepsen 0xJepsen requested a review from FiberedSkies May 8, 2023 15:12
Copy link
Contributor

@FiberedSkies FiberedSkies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lfg!

@FiberedSkies FiberedSkies merged commit c0ab7b6 into main May 8, 2023
@0xJepsen 0xJepsen deleted the waylon/subcommands branch May 15, 2023 05:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add new subcommands for sim
2 participants