Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Colin/portfolio swap #269

Merged
merged 20 commits into from
May 8, 2023
Merged

Colin/portfolio swap #269

merged 20 commits into from
May 8, 2023

Conversation

Autoparallel
Copy link
Collaborator

This is based off of waylon/portfolio-swap but is now further ahead.

@Autoparallel Autoparallel marked this pull request as ready for review May 8, 2023 20:22
@Autoparallel
Copy link
Collaborator Author

Getting to merge conflicts now

@codecov
Copy link

codecov bot commented May 8, 2023

Codecov Report

Merging #269 (ae164a2) into main (23e8b50) will decrease coverage by 1.10%.
The diff coverage is 4.46%.

@@           Coverage Diff            @@
##            main    #269      +/-   ##
========================================
- Coverage   6.92%   5.82%   -1.10%     
========================================
  Files        104     103       -1     
  Lines      26921   30705    +3784     
========================================
- Hits        1863    1790      -73     
- Misses     25058   28915    +3857     
Impacted Files Coverage Δ
crates/bindings/src/assembly_lib.rs 0.00% <ø> (ø)
crates/bindings/src/bisection_lib.rs 0.00% <0.00%> (ø)
crates/bindings/src/echidna_erc20.rs 0.00% <0.00%> (ø)
crates/bindings/src/fee_on_transfer_token.rs 0.00% <ø> (ø)
crates/bindings/src/i_portfolio.rs 0.00% <0.00%> (ø)
crates/bindings/src/i_portfolio_actions.rs 0.00% <0.00%> (ø)
crates/bindings/src/i_portfolio_events.rs 0.00% <ø> (ø)
crates/bindings/src/i_portfolio_getters.rs 0.00% <0.00%> (ø)
crates/bindings/src/invariant.rs 0.00% <ø> (ø)
crates/bindings/src/lib.rs 0.00% <ø> (ø)
... and 17 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@FiberedSkies FiberedSkies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@Autoparallel Autoparallel merged commit d9b3a71 into main May 8, 2023
@0xJepsen 0xJepsen deleted the colin/portfolio_swap branch May 15, 2023 05:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants