Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Colin/portfolio arbitrageur #278

Merged
merged 18 commits into from
May 10, 2023
Merged

Colin/portfolio arbitrageur #278

merged 18 commits into from
May 10, 2023

Conversation

Autoparallel
Copy link
Collaborator

Closes #264

Refactoring of simulations also done here.

@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #278 (24f48e7) into main (e422e13) will decrease coverage by 0.37%.
The diff coverage is 29.17%.

@@           Coverage Diff            @@
##            main    #278      +/-   ##
========================================
- Coverage   5.81%   5.45%   -0.37%     
========================================
  Files        103     105       +2     
  Lines      30740   30894     +154     
========================================
- Hits        1789    1685     -104     
- Misses     28951   29209     +258     
Impacted Files Coverage Δ
crates/cli/src/main.rs 2.08% <0.00%> (ø)
crates/cli/src/sim/portfolio/arbitrage.rs 0.00% <0.00%> (ø)
crates/cli/src/sim/portfolio/mod.rs 0.00% <0.00%> (ø)
crates/cli/src/sim/portfolio/startup.rs 0.00% <0.00%> (ø)
crates/cli/src/sim/uniswap/mod.rs 0.00% <0.00%> (ø)
crates/simulate/src/agent/simple_arbitrageur.rs 94.43% <85.38%> (-2.90%) ⬇️
crates/simulate/src/agent/journaler.rs 93.75% <100.00%> (ø)
crates/simulate/src/agent/mod.rs 85.40% <100.00%> (ø)

... and 3 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Autoparallel Autoparallel marked this pull request as ready for review May 10, 2023 20:20
@Autoparallel
Copy link
Collaborator Author

This currently still has bugs with InvalidInvariant but the logic seems to be working.

Copy link
Contributor

@FiberedSkies FiberedSkies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is awesome!

@FiberedSkies FiberedSkies merged commit 7b1d139 into main May 10, 2023
@0xJepsen 0xJepsen deleted the colin/portfolio-arbitrageur branch May 15, 2023 05:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create SimpleArbitrageur for LiquidExchange <> Portfolio
2 participants