Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Waylon/init build #389

Merged
merged 5 commits into from
Jun 29, 2023
Merged

Waylon/init build #389

merged 5 commits into from
Jun 29, 2023

Conversation

0xJepsen
Copy link
Collaborator

Closes #374
Closes #388

@0xJepsen 0xJepsen added this to the Arbiter CLI milestone Jun 29, 2023
Copy link
Collaborator

@Autoparallel Autoparallel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comments. Also curious about the reasoning behind the file structure choices.

@@ -0,0 +1,26 @@
use std::process::Command;

pub(crate) fn bind_forge() -> std::io::Result<()> {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bind_forge not forge_bind?

let toml = format!(
r#"[package]
name = "{} Simulation"
name = "arbitersim"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was wrong with the other name?

@Autoparallel Autoparallel merged commit dd4cd81 into main Jun 29, 2023
@Autoparallel Autoparallel deleted the waylon/init_build branch August 10, 2023 12:47
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Arbiter bind arbiter bind flag arbiter init flag
2 participants