-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Waylon/tests #424
Merged
Merged
Waylon/tests #424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_warning Waylon/loop termination warning
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug we had with transactions hanging perpetually on a paused environment. This PR adds checks to both the
call
andsend_transaction
method on the middleware to reduce calls that get through. It also added proper error handling on the off chance that some get through they will return an environment error alerting the user that the environment is paused. Some predominant changes for this improvement include:SeqCst
to reduce concurrency bugsTransactionOutcome
enum to theRevmResult
to indicate environment errors to the middlewaresend_transaction
andcall
implementations.cargo fmt
(trying to converge to a happy clippy before release)