Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

config for codecov #446

Merged
merged 5 commits into from
Aug 17, 2023
Merged

config for codecov #446

merged 5 commits into from
Aug 17, 2023

Conversation

0xJepsen
Copy link
Collaborator

@0xJepsen 0xJepsen commented Aug 17, 2023

This closes #438
Waiting for checks to pass then will mark as ready for review.
The changes are with the edition of a codecov.yaml file that overrides the default configuration (which will fail if any pr decreases by coverage by any amount) The file has a threshold value you can set which specifies the amount of change in a pr (up or down) in coverage that will be tolerated. I set it to 1% with a full coverage target of 50%.

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #446 (0e41f53) into main (10c78e1) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #446   +/-   ##
=======================================
  Coverage   58.24%   58.24%           
=======================================
  Files          10       10           
  Lines        2996     2996           
=======================================
  Hits         1745     1745           
  Misses       1251     1251           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@0xJepsen 0xJepsen marked this pull request as ready for review August 17, 2023 21:12
@0xJepsen 0xJepsen requested a review from Autoparallel August 17, 2023 21:12
default:
target: 50%
threshold: 1%
informational: true
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also ensures the patch coverages are strictly informational

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great!

Copy link
Collaborator

@Autoparallel Autoparallel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for getting this chore done

@Autoparallel Autoparallel merged commit 1ac0a1c into main Aug 17, 2023
@Autoparallel Autoparallel deleted the ci/cd/codecov_patch_repo branch August 28, 2023 16:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci/cd: remove codecov/patch and codecov/repo but keep upload to codecov.io
2 participants