Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

bind on init #450

Merged
merged 4 commits into from
Aug 21, 2023
Merged

bind on init #450

merged 4 commits into from
Aug 21, 2023

Conversation

boyle-michael
Copy link
Contributor

This pull request implements the changes requested in issue #428 by changing the init command to also redo the contract bindings.

@Autoparallel
Copy link
Collaborator

Let me clone this and give it a shot.

@Autoparallel Autoparallel self-assigned this Aug 18, 2023
Copy link
Collaborator

@Autoparallel Autoparallel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work for me!

Do you want to consider changing the README to reflect this change?

@codecov
Copy link

codecov bot commented Aug 18, 2023

Codecov Report

Merging #450 (77ca82e) into main (e08f094) will decrease coverage by 0.39%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #450      +/-   ##
==========================================
- Coverage   58.39%   58.00%   -0.39%     
==========================================
  Files          10       10              
  Lines        3002     3022      +20     
==========================================
  Hits         1753     1753              
- Misses       1249     1269      +20     
Files Changed Coverage Δ
bin/init.rs 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Collaborator

@0xJepsen 0xJepsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice lgtm!

@0xJepsen 0xJepsen linked an issue Aug 18, 2023 that may be closed by this pull request
@0xJepsen
Copy link
Collaborator

LEt's get CI passing and we can merge this in

@0xJepsen 0xJepsen merged commit 6bbe842 into anthias-labs:main Aug 21, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: change arbiter init to call arbiter bind upon creation
3 participants